Skip to content

Cherry pick cad49eb to v12.0.2#26399

Merged
danjm merged 1 commit intoVersion-v12.0.2from
cherry-pick-cad49eb-v12.0.2
Aug 13, 2024
Merged

Cherry pick cad49eb to v12.0.2#26399
danjm merged 1 commit intoVersion-v12.0.2from
cherry-pick-cad49eb-v12.0.2

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Aug 13, 2024

Cherry pick #26381 to v12.0.2

…6381)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

We only use this package for its types, so can be treated as a dev
dependency. This will also resolve the audit issue currently seen in
[CI](https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/95274/workflows/b92333ec-1a1c-4ce6-bd7d-7601fe14e1e3/jobs/3546366).

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26381?quickstart=1)

## **Related issues**

Fixes: CI issues, and better reflects the use case of this dependency.

## **Manual testing steps**

Re-test notifications flow

1. Onboard with new or existing wallet
2. Enable notifications
3. Perform a swap on Polygon (a chain we support on-chain notifications
for)
4. See if notifications appear.

For Notification Devs: As there is no feature announcements yet,
manually change the code to point to a portfolio feature announcement.
I've tested and it seems that we still correctly show a feature
announcement to users.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@danjm danjm requested a review from a team as a code owner August 13, 2024 20:35
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm merged commit 84b0007 into Version-v12.0.2 Aug 13, 2024
@danjm danjm deleted the cherry-pick-cad49eb-v12.0.2 branch August 13, 2024 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants