fix: Fix invalid state causing migration 88 to fail#26397
Merged
Conversation
We have found evidence that migration 88 is failing for some users due to a `null` key in the `TokensController.allTokens` state. The migration has been updated to delete any invalid `null`-keys prior to migrating it, preventing the error. Fixes #25938
Gudahtt
commented
Aug 13, 2024
Member
Author
There was a problem hiding this comment.
Strongly recommend using "Hide whitespace" to view this diff, it's only 38 lines with that enabled.
|
danjm
approved these changes
Aug 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26397 +/- ##
===========================================
+ Coverage 70.13% 70.14% +0.01%
===========================================
Files 1435 1435
Lines 50309 50327 +18
Branches 13897 13915 +18
===========================================
+ Hits 35283 35301 +18
Misses 15026 15026 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [47a2415]
Page Load Metrics (66 ± 7 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
commented
Aug 13, 2024
| if (chainId === 'undefined' || chainId === undefined) { | ||
| if ( | ||
| chainId === 'undefined' || | ||
| chainId === undefined || |
Member
Author
There was a problem hiding this comment.
Pretty sure Object.keys would always return undefined as a string literal, do we shouldn't need this condition. But it was already there, so I left it to minimize changes.
I confirmed that using null here didn't work, I needed to check for the string 'null'.
DDDDDanica
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have found evidence that migration 88 is failing for some users due to a
nullkey in theTokensController.allTokensstate. The migration has been updated to delete any invalidnull-keys prior to migrating it, preventing the error.Related issues
Fixes #25938
Manual testing steps
The unit tests demonstrate the affected scenario fairly well. We addressed the "null key" case for a variety of different parts of state, but specifically the one we are seeing in prod is the
allTokensstate having anullkey.Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist