fix: Delete obsolete properties from phishingController and networkControl…#26396
Merged
fix: Delete obsolete properties from phishingController and networkControl…#26396
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Aug 13, 2024
Gudahtt
reviewed
Aug 13, 2024
Gudahtt
requested changes
Aug 13, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Mostly looks good! Just two copy+paste test description errors
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Aug 13, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26396 +/- ##
===========================================
+ Coverage 70.13% 70.14% +0.01%
===========================================
Files 1435 1435
Lines 50309 50326 +17
Branches 13897 13901 +4
===========================================
+ Hits 35283 35300 +17
Misses 15026 15026 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [33cce9a]
Page Load Metrics (161 ± 198 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
approved these changes
Aug 13, 2024
jiexi
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expands on #26383 to delete more obsolete state from the Network and Phishing controllers, to eliminate other sentry errors.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist