feat(snaps): Removed Snaps name-lookup permission code fences#26393
Merged
feat(snaps): Removed Snaps name-lookup permission code fences#26393
Conversation
Member
FrederikBolding
left a comment
There was a problem hiding this comment.
Please enable the E2E in stable: https://github.com/MetaMask/metamask-extension/blob/develop/test/e2e/run-all.js#L12
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26393 +/- ##
===========================================
+ Coverage 70.12% 70.13% +0.01%
===========================================
Files 1434 1435 +1
Lines 50285 50305 +20
Branches 13890 13892 +2
===========================================
+ Hits 35259 35279 +20
Misses 15026 15026 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [e808f91]
Page Load Metrics (55 ± 6 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
FrederikBolding
approved these changes
Aug 15, 2024
Member
There was a problem hiding this comment.
Code LGTM, but please hold off merging until @bowensanders has a look.
david0xd
approved these changes
Aug 15, 2024
7 tasks
Contributor
Author
|
@bowensanders has done QA and approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes code fences for endowment:name-lookup Snap permission, bringing this permission into main build out of Flask.
Related issues
Fixes MetaMask/snaps#2621
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist