Skip to content

fix: Cherrypick f3383ac to Version v12.1#26285

Merged
danjm merged 2 commits intoVersion-v12.1.0from
cherrypick-f3383ac-to-v12.1
Aug 15, 2024
Merged

fix: Cherrypick f3383ac to Version v12.1#26285
danjm merged 2 commits intoVersion-v12.1.0from
cherrypick-f3383ac-to-v12.1

Conversation

@montelaidev
Copy link
Copy Markdown
Contributor

@montelaidev montelaidev commented Aug 1, 2024

Description

This pr cherry picks f3383ac to RC 12.1

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Since the introduction of the new Bitcoin accounts in the
account-list-menu, we introduced a regression regarding the "Show
conversion in testnets" flag (for both Bitcoin and Ethereum accounts).

This PR fixes that.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26224?quickstart=1)

Fixes:
- MetaMask/accounts-planning#545

1. `yarn start:flask`
2. Enable Bitcoin support (Settings > Experimental > Enable "Add a new
Bitcoin*" flags
3. Creates mainnet + testnet Bitcoin accounts
4. Check that the "Show conversion in tesnets" flag is off
5. Open the account menu list (click the header top bar, on the
currently selected account)
6. You should not see any USD prices except for mainnet accounts (you
must be on a mainnet EVM networks to see that for your EVM account)
7. Enables "Show conversion in tesnets" flag
8. Repeat step 5
9. You should now see USD prices also for testnet accounts/test assets

![SCR-20240730-mjje](https://github.com/user-attachments/assets/17b44944-44c8-4480-ae37-5c1236b17a81)

![SCR-20240730-mjme](https://github.com/user-attachments/assets/4cadb111-064c-46d8-b961-5623e2f509a6)

![SCR-20240730-mnlq](https://github.com/user-attachments/assets/32ca75a5-0525-40be-90fe-d05fd83033c3)

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Daniel Rocha <daniel.rocha@consensys.net>
@montelaidev montelaidev requested review from a team as code owners August 1, 2024 14:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev changed the base branch from develop to Version-v12.1.0 August 1, 2024 14:32
@danjm danjm merged commit 188dece into Version-v12.1.0 Aug 15, 2024
@danjm danjm deleted the cherrypick-f3383ac-to-v12.1 branch August 15, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants