fix: remove the ability to send to btc accounts in send page by montelaidev · Pull Request #26271 · MetaMask/metamask-extension

montelaidev · 2024-08-01T07:01:37Z

Description

This PR removes BTC accounts from the account picker and Your Accounts list in the send flow.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/546

Manual testing steps

Create btc account
Select an evm account
Click send
See that the BTC account is not available in Your Accounts
Click the account picker and see that the BTC account is not available.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-08-01T07:01:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-08-01T07:53:10Z

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (20dd2d0) to head (f494669).

Files	Patch %	Lines
...multichain/account-list-menu/account-list-menu.tsx	91.67%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26271      +/-   ##
===========================================
+ Coverage    70.00%   70.01%   +0.01%     
===========================================
  Files         1410     1410              
  Lines        49964    49978      +14     
  Branches     13801    13803       +2     
===========================================
+ Hits         34974    34990      +16     
+ Misses       14990    14988       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-08-01T08:24:48Z

Builds ready [2e1acac]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (154 ± 170 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	249	110	38	18
		domContentLoaded	9	85	32	21	10
		load	42	1698	154	355	170
		domInteractive	9	85	31	22	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 562 Bytes (0.01%)
common: 0 Bytes (0.00%)

danroc · 2024-08-01T09:47:15Z

Tested:

…to allowedAccountTypes

ui/components/multichain/account-list-menu/account-list-menu.test.tsx

ui/components/multichain/account-list-menu/account-list-menu.tsx

ui/selectors/selectors.type.ts

ui/components/multichain/pages/send/components/your-accounts.tsx

ui/components/multichain/pages/send/components/account-picker.test.tsx

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ccharly · 2024-08-01T16:14:31Z

ui/components/multichain/account-list-menu/account-list-menu.tsx

+// eslint-disable-next-line import/no-duplicates
+import { BtcAccountType, EthAccountType } from '@metamask/keyring-api';
 ///: BEGIN:ONLY_INCLUDE_IF(build-flask)
-import { KeyringClient } from '@metamask/keyring-api';
+import {
+  InternalAccount,
+  KeyringAccountType,
+  KeyringClient,
+  // eslint-disable-next-line import/no-duplicates
+} from '@metamask/keyring-api';


Re-posting this one, cause he was not appearing (was outdated). Maybe we can do it like this:

import { EthAccountType ///: BEGIN:ONLY_INCLUDE_IF(build-flask) InternalAccount, KeyringAccountType, KeyringClient, ///: END:ONLY_INCLUDE_IF } from '@metamask/keyring-api'; ///: BEGIN:ONLY_INCLUDE_IF(build-flask) import { Caip2ChainId } from '@metamask/snaps-utils';

ccharly

LGTM + manually tested:

Created accounts:

Account "to" during "Send":

Account "from" during "Send":

metamaskbot · 2024-08-01T17:02:36Z

Builds ready [cf67b29]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (234 ± 238 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	361	121	77	37
		domContentLoaded	10	159	35	37	18
		load	43	1781	234	496	238
		domInteractive	10	158	35	37	18

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 936 Bytes (0.01%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-08-02T00:45:04Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-02T01:12:21Z

Builds ready [f494669]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (678 ± 453 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	358	145	88	42
		domContentLoaded	9	87	30	22	10
		load	40	2645	678	944	453
		domInteractive	9	87	30	22	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 936 Bytes (0.01%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-09-02T11:08:58Z

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.4.0), as PR was cherry-picked in branch 12.2.0.

montelaidev added 4 commits August 1, 2024 14:52

feat: add account-list-menu account type filter

9ecdb80

fix: exclude btc account types in account picker of send

53abca1

fix: add keyrings type in TemporaryBackgroundState type

2e2d5fc

fix: filter btc accounts from SendPageYourAccounts

f99e013

montelaidev self-assigned this Aug 1, 2024

montelaidev added the team-accounts-framework Accounts team label Aug 1, 2024

montelaidev added 2 commits August 1, 2024 15:23

fix: test

9973196

fix: lint

8ef26ee

Merge branch 'develop' into fix/ap-546

2e1acac

montelaidev marked this pull request as ready for review August 1, 2024 08:46

montelaidev requested a review from a team as a code owner August 1, 2024 08:46

montelaidev added 6 commits August 1, 2024 21:14

fix: convert account-list-item to ts and change excludedAccountTypes …

69091be

…to allowedAccountTypes

Merge branch 'develop' into fix/ap-546

5abf86b

fix: lint

903c521

fix: test

b36975f

fix: account picker test

f3a9f5a

fix: lint

6d640ed

ccharly reviewed Aug 1, 2024

View reviewed changes

montelaidev and others added 6 commits August 1, 2024 23:27

Apply suggestions from code review

a8e9a4a

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

refactor: move mockstate to upper scope

aba5745

refactor: use CaipChainId from @metamask/utils

58f3043

fix: update comment and refactor names

eea8d69

refactor: allowedAccountTypes in SendPageYourAccoutns

019695f

fix: remove ts ignore

3f2439d

ccharly reviewed Aug 1, 2024

View reviewed changes

refactor: imports

5591de3

fix: update fence

cf67b29

ccharly approved these changes Aug 1, 2024

View reviewed changes

danroc approved these changes Aug 1, 2024

View reviewed changes

Merge branch 'develop' into fix/ap-546

f494669

montelaidev merged commit fbd1ea1 into develop Aug 2, 2024

montelaidev deleted the fix/ap-546 branch August 2, 2024 03:22

github-actions bot locked and limited conversation to collaborators Aug 2, 2024

metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 2, 2024

metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 2, 2024

Conversation

montelaidev commented Aug 1, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 1, 2024

Uh oh!

codecov bot commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Aug 1, 2024

Uh oh!

danroc commented Aug 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccharly Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Aug 1, 2024

Uh oh!

sonarqubecloud bot commented Aug 2, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Aug 2, 2024

Uh oh!

metamaskbot commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

montelaidev commented Aug 1, 2024 •

edited by github-actions bot

Loading

codecov bot commented Aug 1, 2024 •

edited

Loading