feat: Enable hardware wallets for smart transactions, sign a transaction only once by dan437 · Pull Request #26251 · MetaMask/metamask-extension

dan437 · 2024-07-31T15:26:56Z

Description

This PR enables hardware wallets for smart transactions and uses an already signed transaction from the TransactionController when submitting a smart transaction.

Related issues

Fixes:

Manual testing steps

Enable smart transactions
For example the Send feature now works with a HW wallet + smart transaction
After confirming a tx on a HW device we show the smart transaction status page

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-31T15:27:07Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-07-31T15:46:48Z

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (dd4c2b4) to head (e68fea0).
Report is 8 commits behind head on develop.

Files	Patch %	Lines
ui/pages/swaps/prepare-swap-page/review-quote.js	50.00%	2 Missing ⚠️
app/scripts/metamask-controller.js	0.00%	1 Missing ⚠️
ui/ducks/swaps/swaps.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26251      +/-   ##
===========================================
- Coverage    69.96%   69.96%   -0.00%     
===========================================
  Files         1405     1405              
  Lines        48996    48998       +2     
  Branches     13697    13698       +1     
===========================================
+ Hits         34280    34281       +1     
- Misses       14716    14717       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-31T15:58:05Z

Builds ready [de9053e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (522 ± 374 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	910	177	178	85
		domContentLoaded	10	128	46	36	18
		load	40	2573	522	778	374
		domInteractive	10	128	46	36	18

Bundle size diffs [🚀 Bundle size reduced!]

background: -52 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-15T13:05:54Z

Builds ready [ab541df]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (243 ± 229 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	377	119	61	29
		domContentLoaded	10	172	32	33	16
		load	42	1813	243	477	229
		domInteractive	10	172	32	33	16

Bundle size diffs [🚀 Bundle size reduced!]

background: -52 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-19T11:40:29Z

Builds ready [4a78888]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (83 ± 11 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	247	115	40	19
		domContentLoaded	43	136	79	25	12
		load	49	136	83	23	11
		domInteractive	10	57	31	13	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -52 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-19T13:36:57Z

Builds ready [40e73e7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (61 ± 5 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	111	83	12	6
		domContentLoaded	41	89	58	10	5
		load	47	89	61	10	5
		domInteractive	9	43	22	9	4

Bundle size diffs [🚀 Bundle size reduced!]

background: -52 Bytes (-0.00%)
ui: 21 Bytes (0.00%)
common: 10 Bytes (0.00%)

…ly once Update tests

sonarqubecloud · 2024-08-20T12:16:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-20T13:04:49Z

Builds ready [e68fea0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (72 ± 14 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	279	106	42	20
		domContentLoaded	46	191	68	31	15
		load	53	191	72	30	14
		domInteractive	13	80	28	16	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -52 Bytes (-0.00%)
ui: 21 Bytes (0.00%)
common: 10 Bytes (0.00%)

davibroc

QA Approved

dbrans

LGTM!

martahj

lgtm!

dan437 requested a review from a team as a code owner July 31, 2024 15:26

dan437 added the team-transactions Transactions team label Jul 31, 2024

dan437 marked this pull request as draft July 31, 2024 15:27

dan437 force-pushed the hw-for-stx branch from de9053e to ab541df Compare August 15, 2024 12:32

dan437 force-pushed the hw-for-stx branch from ab541df to 4a78888 Compare August 19, 2024 10:40

dan437 force-pushed the hw-for-stx branch from 4a78888 to 40e73e7 Compare August 19, 2024 12:57

dan437 added 3 commits August 20, 2024 13:47

Enable hardware wallets for smart transactions, sign a transaction on…

166c0e6

…ly once Update tests

setSwapsSTXSubmitLoading(false) on tx cancellation

ca1a438

Set submitClicked to false of STX swap is not loading anymore

e68fea0

dan437 force-pushed the hw-for-stx branch from 40e73e7 to e68fea0 Compare August 20, 2024 12:14

dan437 marked this pull request as ready for review August 20, 2024 12:31

dan437 requested a review from a team as a code owner August 20, 2024 12:31

dan437 requested review from antonydenyer and dbrans August 20, 2024 12:38

davibroc approved these changes Aug 20, 2024

View reviewed changes

dbrans approved these changes Aug 20, 2024

View reviewed changes

martahj approved these changes Aug 20, 2024

View reviewed changes

dan437 merged commit 590f0a9 into develop Aug 21, 2024

dan437 deleted the hw-for-stx branch August 21, 2024 09:46

github-actions bot locked and limited conversation to collaborators Aug 21, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 21, 2024

gauthierpetetin added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Sep 11, 2024

gauthierpetetin removed the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enable hardware wallets for smart transactions, sign a transaction only once#26251

feat: Enable hardware wallets for smart transactions, sign a transaction only once#26251
dan437 merged 3 commits intodevelopfrom
hw-for-stx

dan437 commented Jul 31, 2024 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jul 31, 2024

Uh oh!

codecov bot commented Jul 31, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jul 31, 2024

Uh oh!

metamaskbot commented Aug 15, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

sonarqubecloud bot commented Aug 20, 2024

Uh oh!

metamaskbot commented Aug 20, 2024

Uh oh!

davibroc left a comment

Uh oh!

dbrans left a comment

Uh oh!

martahj left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

dan437 commented Jul 31, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 31, 2024

Uh oh!

codecov bot commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jul 31, 2024

Uh oh!

metamaskbot commented Aug 15, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

sonarqubecloud bot commented Aug 20, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Aug 20, 2024

Uh oh!

davibroc left a comment

Choose a reason for hiding this comment

Uh oh!

dbrans left a comment

Choose a reason for hiding this comment

Uh oh!

martahj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dan437 commented Jul 31, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jul 31, 2024 •

edited

Loading