test(cherry-pick-v12): use tsx for E2E tests instead of ts-node (#25399)#26233
Merged
danjm merged 1 commit intoVersion-v12.0.0from Jul 30, 2024
Merged
test(cherry-pick-v12): use tsx for E2E tests instead of ts-node (#25399)#26233danjm merged 1 commit intoVersion-v12.0.0from
danjm merged 1 commit intoVersion-v12.0.0from
Conversation
On my computer, it took 17 seconds just to launch Mocha for an E2E test. Not launch a browser, not start chromedriver/Ganache, not withFixtures. 17 seconds just to launch Mocha and do nothing. And on CircleCI, this 17 seconds happens thousands of times per workflow. A lot of this time was taken by `ts-node`, which has a very slow startup time. I switched to using `tsx`, which is much much faster. [CircleCI Insights on `develop` showing about 16k credits per workflow](https://app.circleci.com/insights/github/MetaMask/metamask-extension/workflows/test_and_release/overview?branch=develop&reporting-window=last-24-hours) [CircleCI Insights on this branch showing about 12k credits per workflow](https://app.circleci.com/insights/github/MetaMask/metamask-extension/workflows/test_and_release/overview?branch=e2e%2Fuse-tsx&reporting-window=last-24-hours) After this is merged and observed for a bit, it may make sense to rebalance some `parallelism` in `config.yml`. --------- Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.0.0 #26233 +/- ##
================================================
Coverage 65.61% 65.61%
================================================
Files 1368 1368
Lines 54600 54600
Branches 14183 14183
================================================
Hits 35825 35825
Misses 18775 18775 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [d70b650]
Page Load Metrics (145 ± 201 ms)
|
Collaborator
|
No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick d70b650 (#25399) to v12