Skip to content

V12 merge master v11.16.16#26231

Merged
danjm merged 5 commits intoVersion-v12.0.0from
v12-merge-master-v11.16.16
Jul 30, 2024
Merged

V12 merge master v11.16.16#26231
danjm merged 5 commits intoVersion-v12.0.0from
v12-merge-master-v11.16.16

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Jul 30, 2024

No description provided.

danjm and others added 3 commits July 26, 2024 15:56
## **Description**

Update @blockaid/ppom_release package to version 1.5.1

## **Related issues**

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2889

## **Manual testing steps**
NA

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@danjm danjm requested review from a team and kumavis as code owners July 30, 2024 17:44
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm changed the base branch from develop to Version-v12.0.0 July 30, 2024 17:44
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 30, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 30, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/ppom_release@1.5.1 network 0 3.36 MB blockaiduser

🚮 Removed packages: npm/@blockaid/ppom_release@1.4.8

View full report↗︎

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm force-pushed the v12-merge-master-v11.16.16 branch from b8eac46 to d33a8d1 Compare July 30, 2024 19:14
@danjm danjm merged commit d321bda into Version-v12.0.0 Jul 30, 2024
@danjm danjm deleted the v12-merge-master-v11.16.16 branch July 30, 2024 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e1c6d04]
Page Load Metrics (54 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6714287178
domContentLoaded95713105
load4211254157
domInteractive95713105

@metamaskbot metamaskbot added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Aug 19, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was added to branch 12.0.0 when release was cut.

1 similar comment
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was added to branch 12.0.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.0.0 Issue or pull request that will be included in release 12.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants