chore: set bridge selected tokens and amount by micaelae · Pull Request #26212 · MetaMask/metamask-extension

micaelae · 2024-07-30T01:30:36Z

Description

Changes include

redux actions to set the selected src/dest tokens and token amount
redux selectors to get the selected src/dest tokens and token amount

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/METABRIDGE-866

Manual testing steps

N/A. This doesn't change any user functionality, just setting up getters/setters

Screenshots/Recordings

N/A, redux state changes will take effect after UI for inputs is implemented

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-08-16T21:32:17Z

Builds ready [817d1fd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (82 ± 7 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	144	111	18	9
		domContentLoaded	49	102	78	16	8
		load	56	102	82	14	7
		domInteractive	10	53	29	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.09 KiB (0.03%)
ui: 169 Bytes (0.00%)
common: 141 Bytes (0.00%)

codecov · 2024-08-17T03:56:58Z

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.17%. Comparing base (8ffbb54) to head (c861c76).

Files with missing lines	Patch %	Lines
ui/ducks/bridge/bridge.ts	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26212      +/-   ##
===========================================
- Coverage    70.17%   70.17%   -0.00%     
===========================================
  Files         1425     1425              
  Lines        49647    49664      +17     
  Branches     13889    13891       +2     
===========================================
+ Hits         34836    34847      +11     
- Misses       14811    14817       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The base branch was changed.

metamaskbot · 2024-08-22T23:32:26Z

Builds ready [fdff249]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (180 ± 222 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	182	104	24	11
		domContentLoaded	48	138	71	22	11
		load	48	2192	180	462	222
		domInteractive	10	62	29	13	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 169 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-29T00:09:56Z

Builds ready [db01ffb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2114 ± 150 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	663	2577	1999	377	181
		domContentLoaded	1750	3061	2081	315	151
		load	1760	3064	2114	313	150
		domInteractive	16	83	40	19	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 278 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-09-05T23:01:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-05T23:29:36Z

Builds ready [c861c76]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1924 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	242	2423	1843	426	204
		domContentLoaded	1632	2412	1906	205	98
		load	1641	2421	1924	212	102
		domInteractive	14	89	38	17	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 278 Bytes (0.00%)
common: 0 Bytes (0.00%)

infiniteflower

Left a small comment

ui/ducks/bridge/bridge.ts

sonarqubecloud · 2024-09-26T00:14:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-26T00:33:10Z

Builds ready [33f093a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1891 ± 134 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	278	2815	1812	445	214
		domContentLoaded	1567	2703	1859	262	126
		load	1575	2826	1891	280	134
		domInteractive	14	92	48	20	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 254 Bytes (0.00%)
common: 0 Bytes (0.00%)

micaelae requested review from a team as code owners July 30, 2024 01:30

micaelae changed the base branch from develop to mb866-set-network-allowlists July 30, 2024 01:30

micaelae marked this pull request as draft July 30, 2024 01:31

metamaskbot added the team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead label Jul 30, 2024

micaelae force-pushed the mb866-set-network-allowlists branch from d4c9b03 to c1dff19 Compare August 6, 2024 19:55

micaelae force-pushed the mb866-set-token-and-amount branch from 0729ff0 to b4fc0da Compare August 6, 2024 19:55

micaelae force-pushed the mb866-set-network-allowlists branch from c1dff19 to f5366d3 Compare August 12, 2024 22:25

micaelae force-pushed the mb866-set-token-and-amount branch from b4fc0da to f13e6cc Compare August 12, 2024 22:27

micaelae force-pushed the mb866-set-network-allowlists branch 3 times, most recently from f560842 to d428019 Compare August 14, 2024 00:17

micaelae force-pushed the mb866-set-token-and-amount branch from f13e6cc to 2a62d68 Compare August 14, 2024 00:18

micaelae force-pushed the mb866-set-network-allowlists branch from d428019 to f6e295b Compare August 14, 2024 19:02

micaelae force-pushed the mb866-set-token-and-amount branch from 2a62d68 to ea68ad9 Compare August 14, 2024 20:36

micaelae changed the base branch from mb866-set-network-allowlists to develop August 14, 2024 21:27

micaelae removed the request for review from a team August 15, 2024 00:36

micaelae force-pushed the mb866-set-token-and-amount branch from ea68ad9 to 817d1fd Compare August 16, 2024 20:50

micaelae changed the base branch from develop to mb866-set-network-allowlists August 16, 2024 20:54

micaelae marked this pull request as ready for review August 16, 2024 21:16

BZahory previously approved these changes Aug 21, 2024

View reviewed changes

micaelae force-pushed the mb866-set-network-allowlists branch from f673af0 to 09f8605 Compare August 22, 2024 22:05

micaelae force-pushed the mb866-set-token-and-amount branch from 817d1fd to 392d5ff Compare August 22, 2024 22:06

ejwessel previously approved these changes Aug 22, 2024

View reviewed changes

Base automatically changed from mb866-set-network-allowlists to develop August 22, 2024 22:58

micaelae force-pushed the mb866-set-token-and-amount branch from 392d5ff to fdff249 Compare August 22, 2024 23:00

BZahory approved these changes Aug 23, 2024

View reviewed changes

micaelae force-pushed the mb866-set-token-and-amount branch from fdff249 to db01ffb Compare August 28, 2024 23:39

micaelae force-pushed the mb866-set-token-and-amount branch 2 times, most recently from 7ea1060 to c861c76 Compare September 5, 2024 22:59

infiniteflower reviewed Sep 18, 2024

View reviewed changes

ui/ducks/bridge/bridge.ts Outdated Show resolved Hide resolved

chore: add bridge selected token and amount selectors/actions

80312ae

micaelae force-pushed the mb866-set-token-and-amount branch from c861c76 to da72b9a Compare September 25, 2024 22:37

micaelae added 2 commits September 25, 2024 16:56

fix: use null as default state values

4deebf3

chore: add unit tests

33f093a

micaelae force-pushed the mb866-set-token-and-amount branch from da72b9a to 33f093a Compare September 26, 2024 00:01

infiniteflower self-requested a review September 26, 2024 14:32

infiniteflower approved these changes Sep 26, 2024

View reviewed changes

ejwessel approved these changes Sep 27, 2024

View reviewed changes

micaelae merged commit 122867f into develop Sep 27, 2024

micaelae deleted the mb866-set-token-and-amount branch September 27, 2024 00:16

github-actions bot locked and limited conversation to collaborators Sep 27, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: set bridge selected tokens and amount#26212

chore: set bridge selected tokens and amount#26212
micaelae merged 3 commits intodevelopfrom
mb866-set-token-and-amount

micaelae commented Jul 30, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Aug 16, 2024

Uh oh!

codecov bot commented Aug 17, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Aug 22, 2024

Uh oh!

metamaskbot commented Aug 29, 2024

Uh oh!

sonarqubecloud bot commented Sep 5, 2024

Uh oh!

metamaskbot commented Sep 5, 2024

Uh oh!

infiniteflower left a comment •

edited

Loading

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 26, 2024

Uh oh!

metamaskbot commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

micaelae commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Aug 16, 2024

Uh oh!

codecov bot commented Aug 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Aug 22, 2024

Uh oh!

metamaskbot commented Aug 29, 2024

Uh oh!

sonarqubecloud bot commented Sep 5, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Sep 5, 2024

Uh oh!

infiniteflower left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 26, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

micaelae commented Jul 30, 2024 •

edited

Loading

codecov bot commented Aug 17, 2024 •

edited

Loading

infiniteflower left a comment •

edited

Loading