Skip to content

chore: Add en_GB locale#26196

Merged
hjetpoluru merged 1 commit intodevelopfrom
add_en_GB_locale
Jul 29, 2024
Merged

chore: Add en_GB locale#26196
hjetpoluru merged 1 commit intodevelopfrom
add_en_GB_locale

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Jul 29, 2024 •
edited by github-actions bot
Loading

Description

Needed for chrome store description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested a review from a team as a code owner July 29, 2024 17:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Jul 29, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@danjm danjm changed the title Add en_GB locale chore: Add en_GB locale Jul 29, 2024
@hjetpoluru hjetpoluru self-requested a review July 29, 2024 17:37
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 29, 2024

Builds ready [a591ead]
Page Load Metrics (65 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6112794199
domContentLoaded95326157
load419865178
domInteractive95326157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (4bdb994) to head (a591ead).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26196   +/-   ##
========================================
  Coverage    69.97%   69.97%           
========================================
  Files         1409     1409           
  Lines        49840    49840           
  Branches     13775    13775           
========================================
  Hits         34873    34873           
  Misses       14967    14967

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru hjetpoluru merged commit 8dc1c6f into develop Jul 29, 2024
@hjetpoluru hjetpoluru deleted the add_en_GB_locale branch July 29, 2024 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
@metamaskbot metamaskbot added release-12.4.0 Issue or pull request that will be included in release 12.4.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Jul 29, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 30, 2024

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.4.0), as PR was cherry-picked in branch 12.0.0.

@Gudahtt Gudahtt restored the add_en_GB_locale branch January 29, 2025 14:41
@Gudahtt Gudahtt deleted the add_en_GB_locale branch January 29, 2025 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@itsyoboieltr itsyoboieltr itsyoboieltr approved these changes

@hjetpoluru hjetpoluru Awaiting requested review from hjetpoluru

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danjm @metamaskbot @DDDDDanica @itsyoboieltr @hjetpoluru