fix: enable Save button on Add Contact page for address input#26155
Merged
fix: enable Save button on Add Contact page for address input#26155
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Signed-off-by: Mircea Nistor <mirceanis@gmail.com>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26155 +/- ##
===========================================
+ Coverage 69.70% 69.94% +0.24%
===========================================
Files 1409 1409
Lines 49788 49797 +9
Branches 13768 13771 +3
===========================================
+ Hits 34702 34828 +126
+ Misses 15086 14969 -117 ☔ View full report in Codecov by Sentry. |
mirceanis
commented
Jul 26, 2024
Comment on lines
-153
to
+159
| selectedAddress: resolvedAddress, | ||
| input: resolvedAddress, |
Contributor
Author
There was a problem hiding this comment.
This leaves the input field editable after an ENS resolved address has been picked
| setTimeout(() => { | ||
| expect(getByText('Recipient address is invalid')).toBeInTheDocument(); | ||
| }, 100); | ||
| }, 600); |
Contributor
Author
There was a problem hiding this comment.
the debounce timeout is 500ms
Collaborator
Builds ready [92d190c]
Page Load Metrics (154 ± 179 ms)
Bundle size diffs
|
NidhiKJha
reviewed
Jul 29, 2024
| const validEnsAddress = isValidDomainName(input); | ||
|
|
||
| if (!IS_FLASK && !validEnsAddress && !valid) { | ||
| if (!validEnsAddress && !valid) { |
Contributor
Author
There was a problem hiding this comment.
it doesn't matter if we are in FLASK or not, the validation is the same
NidhiKJha
approved these changes
Jul 30, 2024
darkwing
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patches an issue in
add-contact.component.jswhere the disabled state of theSavebutton would disappear only after a successful ENS resolution, effectively preventing plain addresses to be entered.I also added some extra unit tests to check for some of the cases that weren't covered before.
Related issues
fixes #25918
fixes #25889
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist