Skip to content

chore: set bridge network allowlists from feature flags#26147

Merged
micaelae merged 2 commits intodevelopfrom
mb866-set-network-allowlists
Aug 22, 2024
Merged

chore: set bridge network allowlists from feature flags#26147
micaelae merged 2 commits intodevelopfrom
mb866-set-network-allowlists

Conversation

@micaelae
Copy link
Copy Markdown
Member

@micaelae micaelae commented Jul 26, 2024

Description

This change adds controller and redux methods for setting/getting src and dest network allowlists used within the cross-chain swaps experience

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/METABRIDGE-866

Manual testing steps

N/A. This doesn't change any user functionality yet, just setting up getters/setters

Screenshots/Recordings

Sample data added to state:

{
  metamask: {
    bridgeState: {
      srcNetworkAllowlist: ['0x1', '0xa', '0xe708'],
      destNetworkAllowlist: ['0x1', '0xa', '0xe708'],
    }
  }
}

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae requested a review from a team as a code owner July 26, 2024 02:15
@metamaskbot metamaskbot added the team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead label Jul 26, 2024
@micaelae micaelae marked this pull request as draft July 26, 2024 03:04
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d4c9b03]
Page Load Metrics (247 ± 250 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691521022110
domContentLoaded95532147
load411874247521250
domInteractive95532147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.41 KiB (0.13%)
  • ui: 8.58 KiB (0.11%)
  • common: 1.17 KiB (0.02%)

@micaelae micaelae force-pushed the mb866-bridge-controller-v2 branch from d035314 to cfece3b Compare August 6, 2024 19:54
@micaelae micaelae force-pushed the mb866-set-network-allowlists branch from d4c9b03 to c1dff19 Compare August 6, 2024 19:55
@micaelae micaelae force-pushed the mb866-bridge-controller-v2 branch from cfece3b to 23d035d Compare August 12, 2024 22:25
@micaelae micaelae force-pushed the mb866-set-network-allowlists branch 5 times, most recently from 387e52c to f560842 Compare August 13, 2024 23:31
@micaelae micaelae force-pushed the mb866-bridge-controller-v2 branch from 23d035d to bdf1bc2 Compare August 14, 2024 00:17
@micaelae micaelae force-pushed the mb866-set-network-allowlists branch from f560842 to d428019 Compare August 14, 2024 00:17
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f560842]
Page Load Metrics (276 ± 286 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7349814210550
domContentLoaded10282405727
load432086276595286
domInteractive10282405727
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.36 KiB (0.12%)
  • ui: 8.58 KiB (0.12%)
  • common: 1.09 KiB (0.02%)

@micaelae micaelae force-pushed the mb866-bridge-controller-v2 branch from bdf1bc2 to e118e91 Compare August 14, 2024 19:02
@micaelae micaelae force-pushed the mb866-set-network-allowlists branch from d428019 to f6e295b Compare August 14, 2024 19:02
@micaelae micaelae force-pushed the mb866-bridge-controller-v2 branch from e118e91 to 65c14a6 Compare August 14, 2024 21:22
@micaelae micaelae changed the base branch from mb866-bridge-controller-v2 to develop August 14, 2024 21:25
@micaelae micaelae changed the base branch from develop to mb866-bridge-controller-v2 August 14, 2024 21:26
@micaelae micaelae force-pushed the mb866-bridge-controller-v2 branch 2 times, most recently from 7d62780 to bc0be06 Compare August 14, 2024 22:32
@micaelae micaelae force-pushed the mb866-set-network-allowlists branch from f6e295b to 24f771b Compare August 14, 2024 23:52
Base automatically changed from mb866-bridge-controller-v2 to develop August 15, 2024 00:25
@micaelae micaelae force-pushed the mb866-set-network-allowlists branch 4 times, most recently from c299fb6 to f673af0 Compare August 16, 2024 20:48
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c299fb6]
Page Load Metrics (78 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641351022010
domContentLoaded45114742110
load5111478209
domInteractive116528126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.09 KiB (0.03%)
  • ui: 0 Bytes (0.00%)
  • common: 141 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c299fb6]
Page Load Metrics (78 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641351022010
domContentLoaded45114742110
load5111478209
domInteractive116528126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.09 KiB (0.03%)
  • ui: 0 Bytes (0.00%)
  • common: 141 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review August 16, 2024 21:15
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f673af0]
Page Load Metrics (85 ± 11 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint721691092612
domContentLoaded41149812412
load47154852411
domInteractive95730147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.09 KiB (0.03%)
  • ui: 0 Bytes (0.00%)
  • common: 141 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (c965bcc) to head (09f8605).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26147      +/-   ##
===========================================
+ Coverage    70.06%   70.08%   +0.02%     
===========================================
  Files         1411     1412       +1     
  Lines        49210    49238      +28     
  Branches     13760    13763       +3     
===========================================
+ Hits         34477    34505      +28     
  Misses       14733    14733              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BZahory
BZahory previously approved these changes Aug 22, 2024
@sonarqubecloud
Copy link
Copy Markdown

@micaelae micaelae merged commit 857c5fa into develop Aug 22, 2024
@micaelae micaelae deleted the mb866-set-network-allowlists branch August 22, 2024 22:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 22, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [09f8605]
Page Load Metrics (70 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7212894157
domContentLoaded438964147
load509370136
domInteractive125127115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.09 KiB (0.03%)
  • ui: 0 Bytes (0.00%)
  • common: 141 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants