Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
f13dca2 to
690fbc5
Compare
Collaborator
Builds ready [690fbc5]
Page Load Metrics (133 ± 139 ms)
Bundle size diffs
|
690fbc5 to
f704e61
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26106 +/- ##
===========================================
- Coverage 70.13% 70.13% -0.00%
===========================================
Files 1417 1417
Lines 49444 49444
Branches 13835 13835
===========================================
- Hits 34676 34675 -1
- Misses 14768 14769 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [f704e61]
Page Load Metrics (73 ± 10 ms)
Bundle size diffs
|
f704e61 to
4b34d91
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [4b34d91]
Page Load Metrics (162 ± 192 ms)
Bundle size diffs
|
ccharly
reviewed
Jul 25, 2024
seaona
reviewed
Aug 26, 2024
Co-authored-by: seaona <54408225+seaona@users.noreply.github.com>
Collaborator
Builds ready [68280c6]
Page Load Metrics (78 ± 13 ms)
Bundle size diffs
|
Contributor
|
LGTM ! I've followed the steps and it works on my machine (MAC) Screen.Recording.2024-08-30.at.17.19.01.mov |
chloeYue
previously approved these changes
Aug 30, 2024
Collaborator
Builds ready [aa6e393]
Page Load Metrics (1822 ± 74 ms)
Bundle size diffs
|
Gudahtt
requested changes
Aug 30, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Looks great! One suggestion on the CI config changes though, let me know what you think.
|
Collaborator
Builds ready [5c40f6f]
Page Load Metrics (1804 ± 73 ms)
Bundle size diffs
|
hjetpoluru
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it easier to SSH into CircleCI and use VNC.
See the new instructions here:
https://github.com/MetaMask/metamask-extension/blob/develop/docs/ssh-to-circleci.md
(This code and procedure were based on the documentation from CircleCI, which does not work as written https://circleci.com/docs/browser-testing/#interacting-with-the-browser-over-vnc)
Related issues
Manual testing steps
To test this PR, you must "Rerun job with SSH" on branch
circleci-vnc. When the PR is merged, it will work everywhere.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist