Skip to content

fix: update token detection modal css#26025

Merged
chloeYue merged 1 commit intoVersion-v12.1.0from
Version-v12.1.0-fix-css-token-detection-modal
Jul 23, 2024
Merged

fix: update token detection modal css#26025
chloeYue merged 1 commit intoVersion-v12.1.0from
Version-v12.1.0-fix-css-token-detection-modal

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented Jul 22, 2024

Description

Cherry picks #25961

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner July 22, 2024 20:20
@sahar-fehri sahar-fehri requested a review from salimtb July 22, 2024 20:20
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated CSS and layout for token detection modals to enhance visual presentation and user experience.

  • ui/components/app/auto-detect-nft/auto-detect-nft-modal.tsx:

    • Removed TextAlign property from Text component.
    • Added ButtonVariant to cancel button.
    • Updated ModalFooter containerProps to use FlexDirection.ColumnReverse.
  • ui/components/app/auto-detect-token/auto-detect-token-modal.tsx:

    • Removed TextAlign property from Text component.
    • Added ButtonVariant to cancel button.
    • Updated ModalFooter containerProps to use FlexDirection.ColumnReverse.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@chloeYue chloeYue merged commit 656679e into Version-v12.1.0 Jul 23, 2024
@chloeYue chloeYue deleted the Version-v12.1.0-fix-css-token-detection-modal branch July 23, 2024 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants