fix: add ellipsis for permit fiat values#26001
Merged
Conversation
vinistevam
previously approved these changes
Jul 22, 2024
Contributor
|
Great PR @OGPoyraz ! Just a small lint error (jsdocs) failing the pipeline. |
jpuri
previously approved these changes
Jul 22, 2024
matthewwalsh0
requested changes
Jul 22, 2024
matthewwalsh0
previously approved these changes
Jul 22, 2024
475a046
There was a problem hiding this comment.
PR Summary
This PR introduces ellipsis for fiat values exceeding 15 characters in permit simulations to enhance UI readability.
ui/helpers/utils/util.js: AddedskipCharacterInEndparameter toshortenStringfunction for flexible string shortening.ui/helpers/utils/util.test.js: Added test case forshortenStringwithskipCharacterInEndoption.ui/hooks/useFiatFormatter.ts: Introducedshortenoption to handle long fiat values.ui/pages/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx: UpdatedPermitSimulationcomponent to truncate long fiat values.ui/pages/confirmations/components/simulation-details/fiat-display.tsx: Addedshortenprop toIndividualFiatDisplayfor improved fiat value display.
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR introduces ellipsis for fiat values exceeding 15 characters in permit simulations to enhance UI readability.
ui/helpers/utils/util.js: AddedskipCharacterInEndparameter toshortenStringfunction for flexible string shortening.ui/pages/confirmations/components/simulation-details/amount-pill.tsx: UpdatedshortenAssetIdfunction call to includeskipCharacterInEndproperty.ui/pages/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx: UpdatedPermitSimulationcomponent to truncate long fiat values using the newshortenprop inIndividualFiatDisplay.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
jpuri
approved these changes
Jul 23, 2024
Collaborator
Builds ready [d4d259e]
Page Load Metrics (251 ± 266 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26001 +/- ##
===========================================
+ Coverage 69.67% 69.68% +0.01%
===========================================
Files 1401 1404 +3
Lines 49628 49706 +78
Branches 13713 13736 +23
===========================================
+ Hits 34577 34637 +60
- Misses 15051 15069 +18 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
approved these changes
Jul 25, 2024
Contributor
|
Follow-up PR adds tooltip when ellipsis is shown and updates calculation with decimals |
Contributor
|
Cherry-pick PR into 12.1.0 #26515 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR goal is to add ellipsis to the fiat value if it's more than 15 character in permit simulations.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2842
Follow-up Cherry-picked PR:
#26515
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist