Skip to content

chore: upgrade to Sentry 8#25999

Merged
matthewwalsh0 merged 11 commits intodevelopfrom
chore/sentry-upgrade-8
Jul 29, 2024
Merged

chore: upgrade to Sentry 8#25999
matthewwalsh0 merged 11 commits intodevelopfrom
chore/sentry-upgrade-8

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Jul 22, 2024 •
edited
Loading

Description

Upgrade the Sentry packages from 7.53.0 to 8.19.0.

Specifically:

  • Refactor custom FilterEvents integration into object returned by function.
  • Remove usages of hub.
  • Fix notification errors when changing metrics preference.

Open in GitHub Codespaces

Related issues

Manual testing steps

Full Sentry regression.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 22, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sentry-internal/browser-utils@8.19.0 network 0 663 kB sentry-bot
npm/@sentry-internal/feedback@8.19.0 None 0 555 kB sentry-bot
npm/@sentry-internal/replay-canvas@8.19.0 None 0 531 kB sentry-bot
npm/@sentry-internal/replay@8.19.0 None 0 3.73 MB sentry-bot
npm/@sentry/browser@8.19.0 network 0 956 kB sentry-bot
npm/@sentry/core@8.19.0 network 0 1.89 MB sentry-bot
npm/@sentry/types@8.19.0 None 0 329 kB sentry-bot
npm/@sentry/utils@8.19.0 network 0 1.14 MB sentry-bot

🚮 Removed packages: npm/@sentry-internal/tracing@7.53.0, npm/@sentry/browser@7.53.0, npm/@sentry/core@7.53.0, npm/@sentry/integrations@7.53.0, npm/@sentry/replay@7.53.0, npm/@sentry/types@7.53.0, npm/@sentry/utils@7.53.0

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 22, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@sentry-internal/browser-utils@8.19.0, npm/@sentry-internal/feedback@8.19.0, npm/@sentry-internal/replay-canvas@8.19.0, npm/@sentry-internal/replay@8.19.0, npm/@sentry/browser@8.19.0, npm/@sentry/core@8.19.0, npm/@sentry/types@8.19.0, npm/@sentry/utils@8.19.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 22, 2024
@matthewwalsh0 matthewwalsh0 force-pushed the chore/sentry-upgrade-8 branch from 2133854 to cb608f6 Compare July 22, 2024 12:06
@matthewwalsh0
Copy link
Copy Markdown
Member Author

matthewwalsh0 commented Jul 22, 2024

@SocketSecurity ignore-all

matthewwalsh0
matthewwalsh0 commented Jul 22, 2024
View reviewed changes
@matthewwalsh0
Copy link
Copy Markdown
Member Author

matthewwalsh0 commented Jul 22, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 22, 2024

Policies updated

@matthewwalsh0 matthewwalsh0 changed the title refactor: upgrade to Sentry 8 chore: upgrade to Sentry 8 Jul 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (f861486) to head (9dfbdc4).
Report is 3 commits behind head on develop.

Files Patch % Lines
app/scripts/lib/setupSentry.js 0.00% 11 Missing ⚠️
app/scripts/lib/sentry-filter-events.ts 12.50% 7 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25999   +/-   ##
========================================
  Coverage    69.67%   69.68%           
========================================
  Files         1405     1405           
  Lines        49728    49726    -2     
  Branches     13748    13747    -1     
========================================
+ Hits         34646    34647    +1     
+ Misses       15082    15079    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review July 22, 2024 14:38
@matthewwalsh0 matthewwalsh0 requested review from a team and kumavis as code owners July 22, 2024 14:38
greptile-apps[bot]

This comment was marked as duplicate.

Sign in to view

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 22, 2024

Builds ready [341fe90]
Page Load Metrics (294 ± 276 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69140932010
domContentLoaded84020105
load381789294575276
domInteractive84020105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 50 Bytes (0.00%)
  • ui: 117 Bytes (0.00%)
  • common: 127.79 KiB (1.87%)

greptile-apps[bot]

This comment was marked as duplicate.

Sign in to view

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 23, 2024

Builds ready [07f63af]
Page Load Metrics (71 ± 11 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681441002010
domContentLoaded96328199
load42114712311
domInteractive96328199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 60 Bytes (0.00%)
  • ui: 117 Bytes (0.00%)
  • common: 127.79 KiB (1.87%)

greptile-apps[bot]

This comment was marked as duplicate.

Sign in to view

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 23, 2024

Builds ready [cc3f162]
Page Load Metrics (351 ± 328 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint663271238240
domContentLoaded9147243014
load412186351682328
domInteractive9147243014
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 60 Bytes (0.00%)
  • ui: 117 Bytes (0.00%)
  • common: 127.79 KiB (1.87%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 24, 2024

Builds ready [9dfbdc4]
Page Load Metrics (138 ± 156 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8012997147
domContentLoaded96421147
load451555138325156
domInteractive96421147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 60 Bytes (0.00%)
  • ui: 117 Bytes (0.00%)
  • common: 127.79 KiB (1.87%)

greptile-apps[bot]

This comment was marked as duplicate.

Sign in to view

DDDDDanica
DDDDDanica reviewed Jul 25, 2024
View reviewed changes
@DDDDDanica
Copy link
Copy Markdown
Contributor

DDDDDanica commented Jul 25, 2024 •
edited
Loading

Tested locally, work as expected :)

OGPoyraz
OGPoyraz previously approved these changes Jul 29, 2024
View reviewed changes
vinistevam
vinistevam previously approved these changes Jul 29, 2024
View reviewed changes
@DDDDDanica DDDDDanica dismissed stale reviews from vinistevam and OGPoyraz via 2435d0b July 29, 2024 15:54
@matthewwalsh0 matthewwalsh0 force-pushed the chore/sentry-upgrade-8 branch from 2435d0b to 9dfbdc4 Compare July 29, 2024 15:59
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matthewwalsh0 matthewwalsh0 merged commit 4bdb994 into develop Jul 29, 2024
@matthewwalsh0 matthewwalsh0 deleted the chore/sentry-upgrade-8 branch July 29, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 29, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 29, 2024

Builds ready [2566d3d]
Page Load Metrics (666 ± 441 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint754101336933
domContentLoaded119527199
load442424666918441
domInteractive119527199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 60 Bytes (0.00%)
  • ui: 117 Bytes (0.00%)
  • common: 127.79 KiB (1.86%)

@metamaskbot metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Aug 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 28, 2024

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.4.0), as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@OGPoyraz OGPoyraz OGPoyraz left review comments

@vinistevam vinistevam vinistevam left review comments

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthewwalsh0 @metamaskbot @DDDDDanica @OGPoyraz @Prithpal-Sooriya @vinistevam