Skip to content

fix: remove showing nft autodetection modal#25993

Merged
chloeYue merged 1 commit intoVersion-v12.1.0from
Version-v12.1.0-remove-nft-autodetection-modal
Jul 22, 2024
Merged

fix: remove showing nft autodetection modal#25993
chloeYue merged 1 commit intoVersion-v12.1.0from
Version-v12.1.0-remove-nft-autodetection-modal

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented Jul 22, 2024 •
edited by github-actions bot
Loading

Description

Remove showing NFT autodetection modal when user disables it in settings for this version.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner July 22, 2024 06:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 22, 2024

Builds ready [d0ee136]
Page Load Metrics (59 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6911185115
domContentLoaded9261873
load399059136
domInteractive9261873
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -919 Bytes (-0.01%)
  • common: 276 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.59%. Comparing base (c2f65c4) to head (d0ee136).

Additional details and impacted files 
@@               Coverage Diff                @@
##           Version-v12.1.0   #25993   +/-   ##
================================================
  Coverage            69.58%   69.59%           
================================================
  Files                 1360     1360           
  Lines                48216    48212    -4     
  Branches             13311    13307    -4     
================================================
- Hits                 33551    33550    -1     
+ Misses               14665    14662    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahar-fehri sahar-fehri requested review from danjm and salimtb July 22, 2024 06:58
@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 22, 2024
@chloeYue chloeYue merged commit b888411 into Version-v12.1.0 Jul 22, 2024
@chloeYue chloeYue deleted the Version-v12.1.0-remove-nft-autodetection-modal branch July 22, 2024 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@salimtb salimtb salimtb approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sahar-fehri @metamaskbot @salimtb @chloeYue