fix: calcTokenAmount BigNumber more than 15 digits error#25799
Merged
fix: calcTokenAmount BigNumber more than 15 digits error#25799
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
digiwand
commented
Jul 12, 2024
| : totalEthCost; | ||
|
|
||
| const decimalAdjustedDestinationAmount = calcTokenAmount( | ||
| destinationAmount, |
Contributor
Author
There was a problem hiding this comment.
It's expected that the destinationAmount of a Quote is either a string or null. If it was a null, null would be passed to calcTokenAmount. If it was undefined, it would have been a number type. This fixes the type and expected null handling
Collaborator
Builds ready [d960c70]
Page Load Metrics (262 ± 244 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25799 +/- ##
========================================
Coverage 69.77% 69.77%
========================================
Files 1398 1398
Lines 49187 49187
Branches 13580 13580
========================================
+ Hits 34318 34319 +1
+ Misses 14869 14868 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 15, 2024
Collaborator
Builds ready [229a5d5]
Page Load Metrics (227 ± 208 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
matthewwalsh0
requested changes
Jul 17, 2024
This was referenced Jul 17, 2024
matthewwalsh0
approved these changes
Jul 17, 2024
infiniteflower
approved these changes
Jul 17, 2024
Collaborator
Builds ready [dbfb8b8]
Page Load Metrics (301 ± 314 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Explanation:
When certain large params are passed, e.g. when the decimal passed is 36, the calculation of
Math.pow(10, Number(decimals || 0))is → 9.999999999999999e+35. Then, when we pass this to BigNumber div() we get the error:new BigNumber(10).pow(decimals)does not have this rounding issue and can be passed to BigNumber div() without the error.We can see the bignumber.js#div code here
Other notes:
Related issues
Fixes: #13738
Related: #25741 (comment)
Manual testing steps
Screenshots/Recordings
Before
(divisor was previously called multiplier)
After
Pre-merge author checklist
Pre-merge reviewer checklist