feat: support creation of Bitcoin testnet accounts#25772
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
079451d to
0bc54c5
Compare
75a338b to
805ac7b
Compare
Collaborator
Builds ready [805ac7b]
Page Load Metrics (65 ± 7 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25772 +/- ##
===========================================
+ Coverage 69.77% 69.95% +0.18%
===========================================
Files 1376 1394 +18
Lines 48403 48978 +575
Branches 13348 13476 +128
===========================================
+ Hits 33773 34261 +488
- Misses 14630 14717 +87 ☔ View full report in Codecov by Sentry. |
danroc
reviewed
Jul 15, 2024
danroc
reviewed
Jul 15, 2024
danroc
reviewed
Jul 15, 2024
ui/components/multichain/create-btc-account/create-btc-account.tsx
Outdated
Show resolved
Hide resolved
danroc
reviewed
Jul 15, 2024
danroc
reviewed
Jul 15, 2024
Co-authored-by: Daniel Rocha <daniel.rocha@consensys.net>
1ec1120 to
bf2d25f
Compare
danroc
previously approved these changes
Jul 15, 2024
Collaborator
Builds ready [4763e46]
Page Load Metrics (399 ± 387 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Collaborator
Builds ready [42ebe44]
Page Load Metrics (162 ± 203 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danroc
approved these changes
Jul 16, 2024
montelaidev
approved these changes
Jul 16, 2024
Contributor
montelaidev
left a comment
There was a problem hiding this comment.
Tested and works well on 42ebe44
| } | ||
|
|
||
| export function hasCreatedBtcTestnetAccount(state: AccountsState) { | ||
| return hasCreatedBtcAccount(state, isBtcTestnetAddress); |
Contributor
There was a problem hiding this comment.
This isBtcTestnetAddress would return true for a non-EVM and non-BTC address. We can probably address this later when we support other non-EVM chains
Contributor
Author
There was a problem hiding this comment.
Good point, and yes we would need to address this! Let's keep note of that for later
Collaborator
|
Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support of testnet account within the extension following the same pattern than for mainnet accounts with a feature flag.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/511
Manual testing steps
yarn start:flasktb1q...)Screenshots/Recordings
Screen.Recording.2024-07-11.at.16.37.19.mov
Pre-merge author checklist
Pre-merge reviewer checklist