Skip to content

fix: caveat mutations for non-EVM accounts#25739

Merged
montelaidev merged 2 commits intodevelopfrom
fix/remove-non-evm-account
Jul 10, 2024
Merged

fix: caveat mutations for non-EVM accounts#25739
montelaidev merged 2 commits intodevelopfrom
fix/remove-non-evm-account

Conversation

@montelaidev
Copy link
Copy Markdown
Contributor

@montelaidev montelaidev commented Jul 10, 2024

Description

This PR fixes an edge case were the account removal of non EVM accounts is broken if there was an existing EVM dapp permission

Related issues

Fixes:

Manual testing steps

  1. Create BTC account
  2. Switch to evm account
  3. Connect to a dapp
  4. Remove the BTC account successfully.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev added the team-accounts-framework Accounts team label Jul 10, 2024
@montelaidev montelaidev self-assigned this Jul 10, 2024
@montelaidev montelaidev requested a review from a team as a code owner July 10, 2024 12:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly changed the title fix: caveat mutations for non-evm accounts fix: caveat mutations for non-EVM accounts Jul 10, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (7b69e3c) to head (7a8000e).
Report is 34 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #25739      +/-   ##
===========================================
- Coverage    69.66%   69.30%   -0.36%     
===========================================
  Files         1366     1379      +13     
  Lines        48215    51605    +3390     
  Branches     13301    14295     +994     
===========================================
+ Hits         33588    35763    +2175     
- Misses       14627    15842    +1215

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 10, 2024

Builds ready [7a8000e]
Page Load Metrics (389 ± 340 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852961355326
domContentLoaded11121423115
load532243389708340
domInteractive11121423115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -11 Bytes (-0.00%)
  • common: 19 Bytes (0.00%)

@montelaidev montelaidev merged commit 253ca41 into develop Jul 10, 2024
@montelaidev montelaidev deleted the fix/remove-non-evm-account branch July 10, 2024 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ccharly ccharly ccharly approved these changes

@danroc danroc danroc approved these changes

Assignees

@montelaidev montelaidev

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@montelaidev @metamaskbot @ccharly @danroc