cherry-pick: feat improvement for how we display big and small numbers#25720
Merged
jpuri merged 4 commits intoVersion-v12.1.0from Jul 11, 2024
Merged
cherry-pick: feat improvement for how we display big and small numbers#25720jpuri merged 4 commits intoVersion-v12.1.0from
jpuri merged 4 commits intoVersion-v12.1.0from
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [d5c603f]
Page Load Metrics (461 ± 367 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## permit_token_decimal_fix #25720 +/- ##
=========================================================
Coverage 69.58% 69.58%
=========================================================
Files 1360 1360
Lines 48190 48200 +10
Branches 13304 13306 +2
=========================================================
+ Hits 33529 33536 +7
- Misses 14661 14664 +3 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
approved these changes
Jul 10, 2024
pedronfigueiredo
approved these changes
Jul 10, 2024
digiwand
reviewed
Jul 17, 2024
| tokenValue: formatAmount('en-US', valueBN), | ||
| tokenValueMaxPrecision: formatAmountMaxPrecision('en-US', valueBN), | ||
| }; | ||
| }, [tokenDecimals, value]); |
Contributor
There was a problem hiding this comment.
Note there were some issues with this code. We are addressing the issues here:
digiwand
reviewed
Jul 17, 2024
| parseInt(value, 10) / Math.pow(10, tokenDecimals), | ||
| ); | ||
| const tokenValue = formatAmount('en-US', valueBN); | ||
| const tokenValueMaxPrecision = formatAmountMaxPrecision('en-US', valueBN); |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement in how we display big and small token value on permit signature page.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2649
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist