fix: show correct asset and balance when BTC account is the selected account by montelaidev · Pull Request #25719 · MetaMask/metamask-extension

montelaidev · 2024-07-09T15:42:36Z

Description

This PR fixes the asset and balance that is shown in the account list when a BTC account is selected.

Related issues

Fixes https://github.com/MetaMask/accounts-planning/issues/514

Manual testing steps

Create a BTC account
Select the BTC account
Go to a dapp
Connect to the dapp
See that the evm accounts show their native balance and ticker, and the BTC account shows the btc balance and ticker.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-09T15:42:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/selectors/selectors.js

metamaskbot · 2024-07-10T14:33:56Z

Builds ready [95c5e62]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (143 ± 170 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	199	96	30	14
		domContentLoaded	9	58	27	15	7
		load	39	1684	143	354	170
		domInteractive	9	58	27	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -6.92 KiB (-0.10%)
common: 7.51 KiB (0.12%)

metamaskbot · 2024-07-10T15:16:34Z

Builds ready [c78d48c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (171 ± 206 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	303	106	47	22
		domContentLoaded	9	92	28	19	9
		load	40	2035	171	429	206
		domInteractive	9	92	28	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -6.92 KiB (-0.10%)
common: 7.53 KiB (0.12%)

codecov · 2024-07-10T15:16:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.77%. Comparing base (5ee57a6) to head (7dba805).
Report is 21 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25719      +/-   ##
===========================================
- Coverage    69.77%   69.77%   -0.01%     
===========================================
  Files         1376     1377       +1     
  Lines        48403    48502      +99     
  Branches     13348    13378      +30     
===========================================
+ Hits         33773    33839      +66     
- Misses       14630    14663      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ui/selectors/selectors.js

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

sonarqubecloud · 2024-07-10T15:30:38Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-10T16:00:37Z

Builds ready [7dba805]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (305 ± 286 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	335	106	60	29
		domContentLoaded	9	53	25	10	5
		load	42	1940	305	596	286
		domInteractive	9	53	25	10	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -6.92 KiB (-0.10%)
common: 7.53 KiB (0.12%)

danroc

Tested with the branch + develop, LGTM

fix: account list balances

e793e14

montelaidev added the team-accounts-framework Accounts team label Jul 9, 2024

montelaidev self-assigned this Jul 9, 2024

montelaidev added 3 commits July 9, 2024 23:44

fix: lint

1d4e6db

fix: remove log

5e0077b

fix: lint

b2acc9b

montelaidev marked this pull request as ready for review July 10, 2024 08:01

montelaidev requested review from a team as code owners July 10, 2024 08:01

ccharly reviewed Jul 10, 2024

View reviewed changes

ui/selectors/selectors.js Outdated Show resolved Hide resolved

ui/selectors/selectors.js Outdated Show resolved Hide resolved

montelaidev added 6 commits July 10, 2024 16:46

fix: add test

ac02f0a

fix: lint

1ea4b13

fix: multichain amount to decimal

b72aafb

Merge branch 'develop' into fix/ap-514

cb11ae8

fix: storybook

fe23017

fix: lint

95c5e62

danroc changed the title ~~fix: account list balances and ticker shows the correct asset and balance when BTC account is the selected account.~~ fix: account list balances and ticker shows the correct asset and balance when BTC account is the selected account Jul 10, 2024

danroc changed the title ~~fix: account list balances and ticker shows the correct asset and balance when BTC account is the selected account~~ fix: show correct asset and balance when BTC account is the selected account Jul 10, 2024

fix: test

c78d48c

ccharly reviewed Jul 10, 2024

View reviewed changes

ui/selectors/selectors.js Outdated Show resolved Hide resolved

Update ui/selectors/selectors.js

7dba805

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

matthewwalsh0 approved these changes Jul 10, 2024

View reviewed changes

danroc approved these changes Jul 10, 2024

View reviewed changes

ccharly approved these changes Jul 10, 2024

View reviewed changes

montelaidev merged commit d445a4a into develop Jul 10, 2024

montelaidev deleted the fix/ap-514 branch July 10, 2024 16:38

github-actions bot locked and limited conversation to collaborators Jul 10, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: show correct asset and balance when BTC account is the selected account#25719

fix: show correct asset and balance when BTC account is the selected account#25719
montelaidev merged 12 commits intodevelopfrom
fix/ap-514

montelaidev commented Jul 9, 2024 •

edited by danroc

Loading

Uh oh!

github-actions bot commented Jul 9, 2024

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

codecov bot commented Jul 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 10, 2024

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

danroc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

montelaidev commented Jul 9, 2024 • edited by danroc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 9, 2024

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

codecov bot commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 10, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

danroc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

montelaidev commented Jul 9, 2024 •

edited by danroc

Loading

codecov bot commented Jul 10, 2024 •

edited

Loading