Skip to content

cherry-pick: fix decimal places displayed on token value on permit pages#25718

Merged
jpuri merged 1 commit intoVersion-v12.1.0from
permit_token_decimal_fix
Jul 10, 2024
Merged

cherry-pick: fix decimal places displayed on token value on permit pages#25718
jpuri merged 1 commit intoVersion-v12.1.0from
permit_token_decimal_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Jul 9, 2024

Description

fix decimal places displayed on token value on permit pages

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2648

Manual testing steps

  1. Go to test dapp
  2. Submit Permit signature request
  3. Check format of token values displayed

Screenshots/Recordings

Screenshot 2024-06-19 at 3 08 14 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added confirmation-redesign team-confirmations Push issues to confirmations team release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Jul 9, 2024
@jpuri jpuri requested review from a team as code owners July 9, 2024 15:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.58%. Comparing base (43cede8) to head (bb39806).

Files Patch % Lines
ui/pages/confirmations/components/confirm/utils.ts 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           Version-v12.1.0   #25718      +/-   ##
===================================================
+ Coverage            69.57%   69.58%   +0.01%     
===================================================
  Files                 1360     1360              
  Lines                48174    48190      +16     
  Branches             13298    13304       +6     
===================================================
+ Hits                 33514    33529      +15     
- Misses               14660    14661       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 10, 2024

Builds ready [bb39806]
Page Load Metrics (158 ± 161 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681721102211
domContentLoaded1091342211
load411619158336161
domInteractive1091342211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.5 KiB (0.02%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit 811aa05 into Version-v12.1.0 Jul 10, 2024
@jpuri jpuri deleted the permit_token_decimal_fix branch July 10, 2024 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

confirmation-redesign release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpuri @metamaskbot @pedronfigueiredo @matthewwalsh0