Skip to content

fix: version v12.1.0 cherry pick 90d89#25701

Merged
chloeYue merged 1 commit intoVersion-v12.1.0from
Version-v12.1.0-cherry-pick-90d890042f
Jul 5, 2024
Merged

fix: version v12.1.0 cherry pick 90d89#25701
chloeYue merged 1 commit intoVersion-v12.1.0from
Version-v12.1.0-cherry-pick-90d890042f

Conversation

@salimtb
Copy link
Copy Markdown
Contributor

@salimtb salimtb commented Jul 5, 2024

Description

Cherry pick PR for the fix #25601

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
the goal of this PR is to fix some v12.1 bugs related to balance display
and asset picker modal:
- The symbols no longer show for each list item
- Blocked token symbols (e.g., BNB on Ethereum Mainnet) are no longer
greyed out in the UI despite still being inert
- Token names are not truncated
- Token symbol is USD instead of ETH on the asset picker modal
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25601?quickstart=1)

## **Related issues**

Fixes: #25575 

## **Manual testing steps**

1. Go to the wallet view and check crypto and fiat value for native
token
2. Select Ethereum Mainnet
3. Go to Send page
4. Click on destination asset picker
5. Observe that symbols are not present and names are not truncated
6. Search for "CHZ"
7. Observe that it is not styled as a disabled button

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@salimtb salimtb requested a review from a team as a code owner July 5, 2024 13:42
@salimtb salimtb changed the base branch from develop to Version-v12.1.0 July 5, 2024 13:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the title Version v12.1.0 cherry pick 90d890042f Version v12.1.0 cherry pick 90d89 Jul 5, 2024
@salimtb salimtb changed the title Version v12.1.0 cherry pick 90d89 cp: Version v12.1.0 cherry pick 90d89 Jul 5, 2024
@salimtb salimtb changed the title cp: Version v12.1.0 cherry pick 90d89 fix: Version v12.1.0 cherry pick 90d89 Jul 5, 2024
@salimtb salimtb changed the title fix: Version v12.1.0 cherry pick 90d89 fix: version v12.1.0 cherry pick 90d89 Jul 5, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 5, 2024

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jul 5, 2024
@chloeYue chloeYue merged commit 43cede8 into Version-v12.1.0 Jul 5, 2024
@chloeYue chloeYue deleted the Version-v12.1.0-cherry-pick-90d890042f branch July 5, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants