feat(ramps): add flag to ensure ramp networks are only fetched once#25686
Merged
georgeweiler merged 3 commits intodevelopfrom Jul 4, 2024
Merged
feat(ramps): add flag to ensure ramp networks are only fetched once#25686georgeweiler merged 3 commits intodevelopfrom
georgeweiler merged 3 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Collaborator
Builds ready [7fc9901]
Page Load Metrics (333 ± 293 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25686 +/- ##
========================================
Coverage 69.77% 69.77%
========================================
Files 1376 1376
Lines 48397 48403 +6
Branches 13347 13348 +1
========================================
+ Hits 33767 33773 +6
Misses 14630 14630 ☔ View full report in Codecov by Sentry. |
davidmurdoch
approved these changes
Jul 4, 2024
Contributor
davidmurdoch
left a comment
There was a problem hiding this comment.
This is a big improvement in performance/network requests. It also works around a bug currently present in develop. 🚀
danjm
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the rampable networks are only fetched once. There is no need to fetch them again once the array of buyable networks has been received.
Related issues
Fixes: #25649
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist