Skip to content

chore(deps): bump @metamask/accounts-controller from ^17.0.0 to ^17.2.0#25676

Merged
danroc merged 3 commits intodevelopfrom
chore/bump-accounts-controller-17.2.0
Jul 10, 2024
Merged

chore(deps): bump @metamask/accounts-controller from ^17.0.0 to ^17.2.0#25676
danroc merged 3 commits intodevelopfrom
chore/bump-accounts-controller-17.2.0

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Jul 4, 2024 •
edited by github-actions bot
Loading

Description

Bumping @metamask/accounts-controller which provides better support for non-EVM accounts.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 4, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/accounts-controller@17.2.0 Transitive: environment, filesystem, network +35 7.81 MB metamaskbot

🚮 Removed packages: npm/@metamask/accounts-controller@17.1.1

View full report↗︎

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Jul 4, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 4, 2024

Builds ready [1281130]
Page Load Metrics (71 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6514597199
domContentLoaded106929167
load44124712010
domInteractive106929167
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 630 Bytes (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 9, 2024

Builds ready [8d10b05]
Page Load Metrics (169 ± 166 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint753001275928
domContentLoaded1096362412
load451670169347166
domInteractive1096362412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 630 Bytes (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (513cb2c) to head (8d10b05).
Report is 17 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25676   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1366     1366           
  Lines        48244    48244           
  Branches     13302    13302           
========================================
  Hits         33614    33614           
  Misses       14630    14630

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccharly ccharly marked this pull request as ready for review July 10, 2024 11:51
@ccharly ccharly requested a review from a team as a code owner July 10, 2024 11:51
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@danroc danroc merged commit 871f5e7 into develop Jul 10, 2024
@danroc danroc deleted the chore/bump-accounts-controller-17.2.0 branch July 10, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 10, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 10, 2024

Builds ready [75d223d]
Page Load Metrics (95 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint792121203014
domContentLoaded11114412612
load51168953014
domInteractive11113412612
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 630 Bytes (0.02%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danroc danroc danroc approved these changes

@montelaidev montelaidev montelaidev approved these changes

Assignees

No one assigned

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ccharly @metamaskbot @danroc @montelaidev