feat: add BTC experimental toggle by gantunesr · Pull Request #25672 · MetaMask/metamask-extension

gantunesr · 2024-07-04T01:56:58Z

Description

This PR includes the following modifications,

Add a new experimental toggle for BTC accounts
Fixes minor UI bugs
Refactors the pages/settings/experimental-tab files to TypeScript

Note: This change does not affect production build at an UI/UX level

Related issues

Fixes: #486

Manual testing steps

Change the flag BTC_BETA_SUPPORT to true in the builds.yml file
Build the extension client
Go to the experimental settings
See a new toggle called Enable "Add Bitcoin Accounts (Beta)"
The toggle should not have any relevant action on the client

Screenshots/Recordings

Before

After

Screen.Recording.2024-07-10.at.12.27.49.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

gantunesr · 2024-07-04T16:16:50Z

@metamaskbot update-policies

metamaskbot · 2024-07-04T16:28:05Z

Policy update failed. You can review the logs or retry the policy update here

…k-extension into feat/btc-toggle

codecov · 2024-07-05T17:32:36Z

Codecov Report

Attention: Patch coverage is 66.66667% with 24 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (5ee57a6) to head (4d65cd3).
Report is 23 commits behind head on develop.

Files	Patch %	Lines
...gs/experimental-tab/experimental-tab.component.tsx	82.00%	9 Missing ⚠️
...ngs/experimental-tab/experimental-tab.container.ts	28.57%	5 Missing ⚠️
.../multichain/account-list-menu/account-list-menu.js	42.86%	4 Missing ⚠️
ui/store/actions.ts	0.00%	4 Missing ⚠️
ui/selectors/selectors.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25672      +/-   ##
===========================================
- Coverage    69.77%   69.77%   -0.00%     
===========================================
  Files         1376     1378       +2     
  Lines        48403    48560     +157     
  Branches     13348    13390      +42     
===========================================
+ Hits         33773    33881     +108     
- Misses       14630    14679      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-09T19:05:52Z

Builds ready [737b269]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (348 ± 313 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	398	127	80	39
		domContentLoaded	11	106	38	26	12
		load	45	2203	348	652	313
		domInteractive	11	106	38	26	12

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 163 Bytes (0.00%)
ui: -1.56 KiB (-0.02%)
common: 854 Bytes (0.01%)

shared/constants/metametrics.ts

ui/pages/settings/experimental-tab/experimental-tab.component.tsx

github-actions · 2024-07-10T09:59:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

app/_locales/en/messages.json

metamaskbot · 2024-07-10T15:13:35Z

Builds ready [f789263]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (487 ± 384 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	392	124	64	31
		domContentLoaded	11	101	35	20	10
		load	62	2662	487	800	384
		domInteractive	11	101	35	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 163 Bytes (0.00%)
ui: -1.56 KiB (-0.02%)
common: 857 Bytes (0.01%)

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ccharly

LGTM and I've manually tested too:

Screen.Recording.2024-07-10.at.17.31.16.mov

Only the href will need to be updated, but this might be done later!

…k-extension into feat/btc-toggle

ui/components/multichain/account-list-menu/account-list-menu.js

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

sonarqubecloud · 2024-07-10T17:12:00Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-10T19:09:35Z

Builds ready [4d65cd3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (225 ± 226 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	124	98	14	7
		domContentLoaded	10	65	25	14	6
		load	46	1689	225	470	226
		domInteractive	10	65	25	14	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 163 Bytes (0.00%)
ui: -1.56 KiB (-0.02%)
common: 730 Bytes (0.01%)

danroc

Tested, LGTM

ccharly

Also tested, and code looks good! :)

gantunesr added 2 commits July 3, 2024 20:43

chore: add copy

397e05b

feat: add experimental BTC toggle

266dbbd

metamaskbot added the team-accounts-framework Accounts team label Jul 4, 2024

gantunesr added 4 commits July 4, 2024 11:02

refactor: update experiment-tab component to TS

b6a3627

refactor: update experiment-tab container to TS

2567660

chore: update messages file

261e55c

fix: prettier

8fcde18

gantunesr added 5 commits July 4, 2024 12:36

chore: update to use code fence

a114e6f

fix: lint errors

9c7e0a3

refactor: update data types

1a5b731

test: add tests and update mocks

bfbe6aa

Merge branch 'develop' into feat/btc-toggle

7b9b133

gantunesr marked this pull request as ready for review July 5, 2024 12:56

gantunesr requested a review from a team as a code owner July 5, 2024 12:56

gantunesr added 6 commits July 5, 2024 08:56

Merge branch 'develop' into feat/btc-toggle

5f8f30b

chore: solve CI issues

ad1d0f5

Merge branch 'feat/btc-toggle' of https://github.com/MetaMask/metamas…

c0c76ee

…k-extension into feat/btc-toggle

fix: code fenced logic

2e37b0b

fix: lint issues

7190ee1

chore: update test ids

d3cebc7

gantunesr added 7 commits July 5, 2024 13:42

Merge branch 'develop' into feat/btc-toggle

d61b1c3

chore: update snapshots

31010e9

test: add unit test to setBitcoinSupportEnabled

8c6306d

chore: update snapshots

b4821c7

fix: e2e test for request queue

a0b03be

test: update test name

2ed11b1

fix: e2e test for json-rpc/switchEthereumChain

d5fd4b9

ccharly reviewed Jul 10, 2024

View reviewed changes

shared/constants/metametrics.ts Outdated Show resolved Hide resolved

ui/pages/settings/experimental-tab/experimental-tab.component.tsx Outdated Show resolved Hide resolved

Merge branch 'develop' into feat/btc-toggle

2b33044

gantunesr and others added 2 commits July 10, 2024 10:37

chore: update metrics event

e99ef83

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

chore: update metrics event

f789263

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ccharly reviewed Jul 10, 2024

View reviewed changes

app/_locales/en/messages.json Outdated Show resolved Hide resolved

chore: update copy

163511b

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ccharly previously approved these changes Jul 10, 2024

View reviewed changes

montelaidev mentioned this pull request Jul 10, 2024

feat(tests): add btc e2e tests #25663

Merged

7 tasks

montelaidev and others added 4 commits July 11, 2024 00:09

Merge branch 'develop' into feat/btc-toggle

d923f8d

chore: update copy

a88a3bb

Merge branch 'feat/btc-toggle' of https://github.com/MetaMask/metamas…

e330b9d

…k-extension into feat/btc-toggle

chore: hide add account behind feature flag

58cccfe

gantunesr dismissed ccharly’s stale review via 58cccfe July 10, 2024 16:30

gantunesr added 2 commits July 10, 2024 12:45

chore: remove unused message

eb78e50

chore: remove message suffix

7ab583c

ccharly reviewed Jul 10, 2024

View reviewed changes

ui/components/multichain/account-list-menu/account-list-menu.js Outdated Show resolved Hide resolved

gantunesr and others added 3 commits July 10, 2024 12:55

chore: add conditional check to BTC action mode

876af53

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

chore: add code fence back

34b8191

chore: add more code fences

4d65cd3

danroc approved these changes Jul 10, 2024

View reviewed changes

ccharly approved these changes Jul 10, 2024

View reviewed changes

ccharly merged commit ffa7c52 into develop Jul 10, 2024

ccharly deleted the feat/btc-toggle branch July 10, 2024 20:41

github-actions bot locked and limited conversation to collaborators Jul 10, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 10, 2024

Conversation

gantunesr commented Jul 4, 2024 • edited by danroc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

gantunesr commented Jul 4, 2024

Uh oh!

metamaskbot commented Jul 4, 2024

Uh oh!

codecov bot commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jul 9, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

ccharly left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 10, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Jul 10, 2024

Uh oh!

danroc left a comment

Choose a reason for hiding this comment

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gantunesr commented Jul 4, 2024 •

edited by danroc

Loading

codecov bot commented Jul 5, 2024 •

edited

Loading

ccharly left a comment •

edited

Loading