fix: allow ramps dev environment on Flask by danroc · Pull Request #25659 · MetaMask/metamask-extension

danroc · 2024-07-03T14:52:38Z

Description

Allow https://ramps-dev.portfolio.metamask.io send requests to non-EVM account Snaps on Flask.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/509

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-03T14:52:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-07-03T15:40:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (e0db3ef) to head (90c9282).
Report is 12 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25659   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1366     1366           
  Lines        48231    48231           
  Branches     13304    13304           
========================================
  Hits         33604    33604           
  Misses       14627    14627

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-03T15:52:29Z

Builds ready [6a3259e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (218 ± 226 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	151	98	20	10
		domContentLoaded	9	39	22	8	4
		load	43	1730	218	471	226
		domInteractive	9	39	22	8	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 10 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-07-03T16:50:56Z

Builds ready [a174a16]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (260 ± 276 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	205	112	31	15
		domContentLoaded	10	71	35	19	9
		load	44	2382	260	575	276
		domInteractive	10	71	35	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 10 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-07-04T15:16:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-04T15:44:09Z

Builds ready [90c9282]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (201 ± 251 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	369	124	59	28
		domContentLoaded	11	73	37	20	9
		load	49	2476	201	522	251
		domInteractive	11	73	37	20	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 10 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

fix: allow ramps dev environment on Flask

6a3259e

danroc requested a review from a team as a code owner July 3, 2024 14:52

danroc self-assigned this Jul 3, 2024

danroc added the team-accounts-framework Accounts team label Jul 3, 2024

chore: add another dev origin

a174a16

test: also test dev origins

12ffede

gantunesr previously approved these changes Jul 4, 2024

View reviewed changes

test: fix Portfolio unit tests

90c9282

danroc dismissed gantunesr’s stale review via 90c9282 July 4, 2024 15:14

gantunesr approved these changes Jul 4, 2024

View reviewed changes

ccharly approved these changes Jul 4, 2024

View reviewed changes

ccharly merged commit 31d0c3f into develop Jul 4, 2024

ccharly deleted the dr/portfolio-staging branch July 4, 2024 15:57

github-actions bot locked and limited conversation to collaborators Jul 4, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow ramps dev environment on Flask#25659

fix: allow ramps dev environment on Flask#25659
ccharly merged 4 commits intodevelopfrom
dr/portfolio-staging

danroc commented Jul 3, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 3, 2024

Uh oh!

codecov bot commented Jul 3, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

sonarqubecloud bot commented Jul 4, 2024

Uh oh!

metamaskbot commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

danroc commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 3, 2024

Uh oh!

codecov bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

sonarqubecloud bot commented Jul 4, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danroc commented Jul 3, 2024 •

edited

Loading

codecov bot commented Jul 3, 2024 •

edited

Loading