Jl/caip multichain/permission validation#25647
Merged
jiexi merged 7 commits intojl/mmp-2360/caip-25-pocfrom Jul 3, 2024
Merged
Jl/caip multichain/permission validation#25647jiexi merged 7 commits intojl/mmp-2360/caip-25-pocfrom
jiexi merged 7 commits intojl/mmp-2360/caip-25-pocfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
shanejonas
reviewed
Jul 3, 2024
| } from '@metamask/permission-controller'; | ||
| import { CaveatMutatorOperation } from '@metamask/permission-controller'; | ||
| import { PermissionType, SubjectType } from '@metamask/permission-controller'; | ||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
some merge conflict thingies
shanejonas
reviewed
Jul 3, 2024
| findNetworkClientIdByChainId: | ||
| this.networkController.findNetworkClientIdByChainId.bind( | ||
| this.networkController, | ||
| ), |
Contributor
There was a problem hiding this comment.
is this needed? it was already a hook. this gets passed to the network controller which i dont think takes this
shanejonas
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist