Sj/caip 25 poc mutator#25643
Merged
shanejonas merged 5 commits intojl/mmp-2360/caip-25-pocfrom Jul 3, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
shanejonas
commented
Jul 2, 2024
shanejonas
commented
Jul 2, 2024
jiexi
reviewed
Jul 2, 2024
jiexi
reviewed
Jul 3, 2024
Comment on lines
+120
to
+127
| return { | ||
| operation: CaveatMutatorOperation.updateValue, | ||
| value: { | ||
| requiredScopes: newRequiredScopes.reduce(reduceKeysHelper, {}), | ||
| optionalScopes: newOptionalScopes.reduce(reduceKeysHelper, {}), | ||
| }, | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
need to update mergedScopes too, but i'm starting to question if mergedScopes needs to exist in the caveat now
jiexi
reviewed
Jul 3, 2024
| }; | ||
| } | ||
|
|
||
| if (!requiredScopesRemoved && !optionalScopesRemoved) { |
jiexi
reviewed
Jul 3, 2024
| }; | ||
| } | ||
|
|
||
| if (!requiredScopesRemoved && optionalScopesRemoved) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!requiredScopesRemoved && optionalScopesRemoved) { | |
| if (optionalScopesRemoved) { |
jiexi
reviewed
Jul 3, 2024
| const optionalScopesRemoved = | ||
| newOptionalScopes.length !== Object.entries(existingScopes.optionalScopes).length; | ||
|
|
||
| if (requiredScopesRemoved) { |
Member
There was a problem hiding this comment.
this can probably just be a check for existingScopes.requiredScopes[targetScopeString]? nit i suppose
Contributor
Author
There was a problem hiding this comment.
ill leave this in in case we need to support removing multiple scopes at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist