feat: added check for if the selected account is BTC in transaction-list by k-g-j · Pull Request #25642 · MetaMask/metamask-extension

k-g-j · 2024-07-02T20:57:44Z

Description

Updates the activity tab view to display the message "Bitcoin activity is not supported" if the selected account is a Bitcoin account. It also adds a button to redirect to the Bitcoin block explorer.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/499

Manual testing steps

Create a Bitcoin account
1. Clone the Bitcoin Manager snap
2. Change emitEvents here from false to true
3. Run yarn && yarn start
4. Go to http://localhost:8000/
5. Create a Bitcoin account

Ensure that the new Bitcoin account is your selected account and navigate to the activity tab in the extension
You should see the message "Bitcoin activity is not supported"
You should see a button that says "View on block explorer" that opens to "https://blockstream.info/testnet/address/YourBitcoinAddress"

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-02T20:57:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-07-03T16:29:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (363a8f4) to head (53264ac).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25642      +/-   ##
===========================================
+ Coverage    69.67%   69.67%   +0.01%     
===========================================
  Files         1366     1366              
  Lines        48240    48249       +9     
  Branches     13307    13308       +1     
===========================================
+ Hits         33607    33616       +9     
  Misses       14633    14633

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-03T16:41:20Z

Builds ready [76e4879]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (136 ± 142 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	270	100	42	20
		domContentLoaded	9	71	29	15	7
		load	39	1419	136	296	142
		domInteractive	9	71	29	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.29 KiB (0.03%)
common: 74 Bytes (0.00%)

ui/components/app/transaction-list/transaction-list.test.js

metamaskbot · 2024-07-03T17:32:16Z

Builds ready [4a2ec33]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (147 ± 162 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	141	102	16	8
		domContentLoaded	9	51	28	13	6
		load	44	1619	147	338	162
		domInteractive	9	51	28	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.29 KiB (0.03%)
common: 74 Bytes (0.00%)

metamaskbot · 2024-07-03T19:06:31Z

Builds ready [7b880d2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (145 ± 158 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	268	100	43	20
		domContentLoaded	8	77	32	19	9
		load	39	1577	145	330	158
		domInteractive	8	77	32	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.29 KiB (0.03%)
common: 74 Bytes (0.00%)

…ng to true

sonarqubecloud · 2024-07-03T22:11:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-03T23:27:38Z

Builds ready [53264ac]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (69 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	126	98	14	7
		domContentLoaded	10	57	26	13	6
		load	47	107	69	16	8
		domInteractive	10	57	26	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.29 KiB (0.03%)
common: 74 Bytes (0.00%)

ccharly

LGTM, also tested manually on my side 👍

ccharly · 2024-07-04T09:12:11Z

Just adding a quick recording too:

Screen.Recording.2024-07-04.at.11.10.42.mov

danroc

I tested it, LGTM, thanks @k-g-j!

feat: added check for if the selected account is btc in transaction-list

3caa1a1

metamaskbot added the team-accounts-framework Accounts team label Jul 2, 2024

k-g-j added the area-UI Relating to the user interface. label Jul 2, 2024

k-g-j and others added 5 commits July 2, 2024 17:12

fix: lint errors

59a03c9

Merge branch 'develop' into feat/update-btc-activity-view

43de124

feat: updated btc activity conditional rendering and styling

78ff1a1

fix: block explorer testnet in transaction-list.test.js

cde5c3a

feat: refactored openBlockExplorer

5c27927

k-g-j marked this pull request as ready for review July 3, 2024 15:51

k-g-j requested a review from a team as a code owner July 3, 2024 15:51

k-g-j and others added 2 commits July 3, 2024 11:51

Merge branch 'develop' into feat/update-btc-activity-view

44713c0

fix: moved imports from code fencing

76e4879

ccharly reviewed Jul 3, 2024

View reviewed changes

feat: updated tests

4a2ec33

Merge branch 'develop' into feat/update-btc-activity-view

7b880d2

k-g-j and others added 2 commits July 3, 2024 18:07

feat: updated test to remove providerConfig and set completedOnboardi…

a4faff6

…ng to true

Merge branch 'develop' into feat/update-btc-activity-view

53264ac

ccharly approved these changes Jul 4, 2024

View reviewed changes

danroc approved these changes Jul 4, 2024

View reviewed changes

danroc merged commit d0a0227 into develop Jul 4, 2024

danroc deleted the feat/update-btc-activity-view branch July 4, 2024 14:01

danroc changed the title ~~feat: added check for if the selected account is btc in transaction-list~~ feat: added check for if the selected account is BTC in transaction-list Jul 4, 2024

github-actions bot locked and limited conversation to collaborators Jul 4, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added check for if the selected account is BTC in transaction-list#25642

feat: added check for if the selected account is BTC in transaction-list#25642
danroc merged 12 commits intodevelopfrom
feat/update-btc-activity-view

k-g-j commented Jul 2, 2024 •

edited by gantunesr

Loading

Uh oh!

github-actions bot commented Jul 2, 2024

Uh oh!

codecov bot commented Jul 3, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

sonarqubecloud bot commented Jul 3, 2024

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

ccharly left a comment

Uh oh!

ccharly commented Jul 4, 2024

Uh oh!

danroc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

k-g-j commented Jul 2, 2024 • edited by gantunesr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 2, 2024

Uh oh!

codecov bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

sonarqubecloud bot commented Jul 3, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Jul 3, 2024

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

ccharly commented Jul 4, 2024

Uh oh!

danroc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

k-g-j commented Jul 2, 2024 •

edited by gantunesr

Loading

codecov bot commented Jul 3, 2024 •

edited

Loading