Skip to content

fix: Fix page width for fullscreen mode send page#25639

Merged
darkwing merged 1 commit intodevelopfrom
hm/fix-fullscreen-send-page
Jul 11, 2024
Merged

fix: Fix page width for fullscreen mode send page#25639
darkwing merged 1 commit intodevelopfrom
hm/fix-fullscreen-send-page

Conversation

@hmalik88
Copy link
Copy Markdown
Contributor

@hmalik88 hmalik88 commented Jul 2, 2024 •
edited
Loading

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? The send page was too wide in full screen mode
  2. What is the improvement/solution? Added a media query to handle page width in fulls screen mode.

Manual testing steps

  1. Build the extension
  2. Open the send screen in full page view

Screenshots/Recordings

Before

MetaMask.-.Brave.2024-06-13.15-56-48.mp4

After

Screenshot 2024-07-02 at 12 48 32 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 2, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot metamaskbot added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Jul 2, 2024
@hmalik88 hmalik88 added team-extension-platform Extension Platform team and removed INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) labels Jul 2, 2024
@hmalik88 hmalik88 marked this pull request as ready for review July 2, 2024 16:57
@hmalik88 hmalik88 requested a review from a team as a code owner July 2, 2024 16:57
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (7b69e3c) to head (089c41c).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25639   +/-   ##
========================================
  Coverage    69.66%   69.66%           
========================================
  Files         1366     1366           
  Lines        48215    48215           
  Branches     13301    13301           
========================================
  Hits         33588    33588           
  Misses       14627    14627

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [089c41c]
Page Load Metrics (236 ± 234 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint76143103168
domContentLoaded116931147
load441764236487234
domInteractive116931147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 2, 2024
@darkwing darkwing merged commit 2726c5d into develop Jul 11, 2024
@darkwing darkwing deleted the hm/fix-fullscreen-send-page branch July 11, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 11, 2024
@metamaskbot metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Aug 19, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 19, 2024

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@darkwing darkwing darkwing approved these changes

@BZahory BZahory BZahory approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmalik88 @metamaskbot @darkwing @BZahory