Skip to content

feat: define which keyring methods Portfolio can call#25633

Merged
ccharly merged 2 commits intodevelopfrom
dr/portfolio-permissions
Jul 2, 2024
Merged

feat: define which keyring methods Portfolio can call#25633
ccharly merged 2 commits intodevelopfrom
dr/portfolio-permissions

Conversation

@danroc
Copy link
Copy Markdown
Contributor

@danroc danroc commented Jul 2, 2024 •
edited by github-actions bot
Loading

Description

This PR adds a special case for Portfolio to allow it to call submitRequest and getAccountsBalances methods of a keyring Snap needed to support the BTC Snap, alongside other management methods (listAccounts and getAccount).

Open in GitHub Codespaces

Related issues

Resolves: https://github.com/MetaMask/accounts-planning/issues/506

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danroc danroc added the team-accounts-framework Accounts team label Jul 2, 2024
@danroc danroc self-assigned this Jul 2, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (7b69e3c) to head (1c3d3db).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25633   +/-   ##
========================================
  Coverage    69.66%   69.66%           
========================================
  Files         1366     1366           
  Lines        48215    48215           
  Branches     13301    13301           
========================================
  Hits         33588    33588           
  Misses       14627    14627

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [1c3d3db]
Page Load Metrics (170 ± 182 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint625401219847
domContentLoaded9242394924
load421779170379182
domInteractive9242394924
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 189 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danroc danroc marked this pull request as ready for review July 2, 2024 16:22
@danroc danroc requested a review from a team as a code owner July 2, 2024 16:22
@ccharly ccharly merged commit da932ae into develop Jul 2, 2024
@ccharly ccharly deleted the dr/portfolio-permissions branch July 2, 2024 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ccharly ccharly ccharly approved these changes

@montelaidev montelaidev montelaidev approved these changes

Assignees

@danroc danroc

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danroc @metamaskbot @ccharly @montelaidev