chore: updates MMI custody controller#25631
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask-institutional/custody-controller@0.2.30 |
Collaborator
Builds ready [17b8446]
Page Load Metrics (66 ± 8 ms)
Bundle size diffs
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25631 +/- ##
========================================
Coverage 69.66% 69.66%
========================================
Files 1366 1366
Lines 48215 48215
Branches 13301 13301
========================================
Hits 33588 33588
Misses 14627 14627 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [1ee2bbf]
Page Load Metrics (79 ± 30 ms)
Bundle size diffs
|
albertolive
approved these changes
Jul 3, 2024
vinistevam
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates MMI controller to latest version, we've updated a method to filter out two custodians that are not used anymore.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist