Skip to content

fix: show connected toast only for EVM accounts#25628

Merged
danroc merged 2 commits intodevelopfrom
fix/non-evm-toast
Jul 4, 2024
Merged

fix: show connected toast only for EVM accounts#25628
danroc merged 2 commits intodevelopfrom
fix/non-evm-toast

Conversation

@montelaidev
Copy link
Copy Markdown
Contributor

@montelaidev montelaidev commented Jul 2, 2024 •
edited by danroc
Loading

Description

When there is one account connected to a dapp, the Connected Toast is shown for the BTC account. This PR hides the toast for non-EVM accounts.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/508

Manual testing steps

  1. Connect an account to a dapp
  2. Add a BTC account
  3. Click on the MM popup and see that there isn't a connection toast being shown.

Screenshots/Recordings

Before

Screenshot 2024-07-02 at 23 49 21

After

Screenshot 2024-07-02 at 23 49 04

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Jul 2, 2024
@montelaidev montelaidev self-assigned this Jul 2, 2024
@montelaidev montelaidev marked this pull request as ready for review July 2, 2024 15:50
@montelaidev montelaidev requested a review from a team as a code owner July 2, 2024 15:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ccharly
ccharly approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my side, works fine!

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.68%. Comparing base (7b69e3c) to head (c796f71).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #25628      +/-   ##
===========================================
+ Coverage    69.66%   69.68%   +0.02%     
===========================================
  Files         1366     1366              
  Lines        48215    48218       +3     
  Branches     13301    13303       +2     
===========================================
+ Hits         33588    33598      +10     
+ Misses       14627    14620       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 3, 2024

Builds ready [c796f71]
Page Load Metrics (141 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732931064522
domContentLoaded99132199
load481414141294141
domInteractive99132199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 244 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danroc danroc changed the title fix: show connected toast only for evm accounts fix: show connected toast only for EVM accounts Jul 3, 2024
@danroc danroc merged commit 44939a2 into develop Jul 4, 2024
@danroc danroc deleted the fix/non-evm-toast branch July 4, 2024 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ccharly ccharly ccharly approved these changes

@danroc danroc danroc approved these changes

Assignees

@montelaidev montelaidev

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@montelaidev @metamaskbot @ccharly @danroc