Skip to content

feat: update Permit Signature Redesign "Spending cap" copy#25618

Merged
digiwand merged 2 commits intodevelopfrom
feat-update-permit-redesign-spending-cap-copy
Jul 2, 2024
Merged

feat: update Permit Signature Redesign "Spending cap" copy#25618
digiwand merged 2 commits intodevelopfrom
feat-update-permit-redesign-spending-cap-copy

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Jul 1, 2024 •
edited by github-actions bot
Loading

Description

Updates Permit signature redesign copy "Approve spend limit" → "Spending cap"

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2719

Manual testing steps

  1. Go to test dapp
  2. Click on Malicious Permit within the ppom section

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner July 1, 2024 20:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the team-confirmations Push issues to confirmations team label Jul 1, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (7d94797) to head (7a95f8d).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25618   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48173    48173           
  Branches     13291    13291           
========================================
  Hits         33527    33527           
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [7a95f8d]
Page Load Metrics (344 ± 294 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861571222211
domContentLoaded115933157
load611894344613294
domInteractive115933157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand digiwand merged commit c9fcc14 into develop Jul 2, 2024
@digiwand digiwand deleted the feat-update-permit-redesign-spending-cap-copy branch July 2, 2024 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
@digiwand digiwand added release-12.1.0 Issue or pull request that will be included in release 12.1.0 and removed release-12.2.0 Issue or pull request that will be included in release 12.2.0 labels Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@digiwand @metamaskbot @jpuri @matthewwalsh0