fix: Remove unused fixtures and fix test name in smart swaps disabled spec#25616
Merged
plasmacorral merged 3 commits intodevelopfrom Jul 2, 2024
Merged
fix: Remove unused fixtures and fix test name in smart swaps disabled spec#25616plasmacorral merged 3 commits intodevelopfrom
plasmacorral merged 3 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25616 +/- ##
========================================
Coverage 69.60% 69.60%
========================================
Files 1364 1364
Lines 48172 48172
Branches 13291 13291
========================================
Hits 33526 33526
Misses 14646 14646 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [cedb87c]
Page Load Metrics (152 ± 187 ms)
Bundle size diffs
|
gantunesr
reviewed
Jul 2, 2024
Member
gantunesr
left a comment
There was a problem hiding this comment.
Since you're already changing this file, lets update the name of the test
describe('Snap Account - Smart Swaps', function (this: Suite) {
it('checks if smart swaps are disabled for snap accounts', async function () {
...
}
}
|
Collaborator
Builds ready [52bc178]
Page Load Metrics (65 ± 8 ms)
Bundle size diffs
|
chloeYue
approved these changes
Jul 2, 2024
Contributor
chloeYue
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adjusting this !
seaona
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test name was not being captured correctly and recently came to appreciate that some of the snap account related fixtures were not actually needed for this test.
Updated test name and removed
accountSnapFixturesRelated issues
Fixes: 505
Manual testing steps
Firefox:
yarn build:test:mv2thenENABLE_MV3=false yarn test:e2e:single test/e2e/accounts/smart-swap-disabled.spec.ts --browser=firefoxChrome:
yarn build:testthenyarn test:e2e:single test/e2e/accounts/smart-swap-disabled.spec.ts --browser=chromeScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist