Skip to content

feat: added BTC variant to ramps-card and illustration image#25615

Merged
k-g-j merged 4 commits intodevelopfrom
feat/buy-btc-banner
Jul 2, 2024
Merged

feat: added BTC variant to ramps-card and illustration image#25615
k-g-j merged 4 commits intodevelopfrom
feat/buy-btc-banner

Conversation

@k-g-j
Copy link
Copy Markdown
Contributor

@k-g-j k-g-j commented Jul 1, 2024 •
edited
Loading

Description

Updates the Ramps banners for BTC accounts.

Added

  • BTC to RAMPS_CARD_VARIANT_TYPES with illustractionSrc, gradient, title, and body in the RAMPS_CARD_VARIANTS
  • BTC illustration to app/images
  • BtcBanner to RampsMetaMaskEntry enum

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/496

Manual testing steps

N/A
@georgeweiler is working on subsequent PR to include BTC in the list of buyable tokens, which will render the new banner in that flow.

Screenshots/Recordings

Screenshot 2024-07-01 at 3 50 59 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Jul 1, 2024
@k-g-j k-g-j added the area-UI Relating to the user interface. label Jul 1, 2024
@k-g-j k-g-j marked this pull request as ready for review July 1, 2024 19:52
@k-g-j k-g-j requested a review from a team as a code owner July 1, 2024 19:52
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [ba02869]
Page Load Metrics (476 ± 345 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint704001267235
domContentLoaded1097302010
load572190476719345
domInteractive1097302010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 323 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (548b54a) to head (9102b0e).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25615   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48173    48173           
  Branches     13291    13291           
========================================
  Hits         33527    33527           
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@k-g-j k-g-j merged commit 05904ca into develop Jul 2, 2024
@k-g-j k-g-j deleted the feat/buy-btc-banner branch July 2, 2024 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

No one assigned

Labels

area-UI Relating to the user interface. release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k-g-j @metamaskbot @georgeweiler @gantunesr