Skip to content

feat: add SIWE mismatch account warning alert #25613

Merged
digiwand merged 7 commits intodevelopfrom
feat-siwe-account-mismatch-alert
Jul 2, 2024
Merged

feat: add SIWE mismatch account warning alert #25613
digiwand merged 7 commits intodevelopfrom
feat-siwe-account-mismatch-alert

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Jul 1, 2024 •
edited
Loading

Description

Adds account mismatch warning alert to SIWE redesign page, "Signing in with" row

Open in GitHub Codespaces

Related issues

Fixes: #25317

Manual testing steps

  1. comment out isSIWE condition in ui/pages/confirmations/hooks/useCurrentConfirmation.ts file
  2. turn on redesign in Experimental Settings
  3. yarn start
  4. Go to test-dapp and test SIWE Bad Account button

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested review from a team as code owners July 1, 2024 17:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand changed the title Feat siwe account mismatch alert feat: add SIWE mismatch account warning alert Jul 1, 2024
@digiwand digiwand added the team-confirmations Push issues to confirmations team label Jul 1, 2024
@digiwand digiwand mentioned this pull request Jul 1, 2024
Closed
7 tasks
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.61%. Comparing base (c641981) to head (e0c0f77).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #25613      +/-   ##
===========================================
+ Coverage    69.60%   69.61%   +0.01%     
===========================================
  Files         1364     1365       +1     
  Lines        48173    48187      +14     
  Branches     13291    13293       +2     
===========================================
+ Hits         33527    33541      +14     
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [e0c0f77]
Page Load Metrics (324 ± 285 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint672691154722
domContentLoaded115330126
load441867324593285
domInteractive115330126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.45 KiB (0.04%)
  • common: 153 Bytes (0.00%)

@digiwand digiwand merged commit d0c11e4 into develop Jul 2, 2024
@digiwand digiwand deleted the feat-siwe-account-mismatch-alert branch July 2, 2024 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@vinistevam vinistevam Awaiting requested review from vinistevam

Assignees

No one assigned

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redesign Signature SIWE: add non-critical alert for account missmatch

4 participants

@digiwand @metamaskbot @jpuri @matthewwalsh0