fix: Skip blockaid validation for SIWE signature types#25612
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
||
| it('does not do validation for SIWE signature', async () => { | ||
| const middlewareFunction = createMiddleware({ | ||
| securityAlertsEnabled: false, |
There was a problem hiding this comment.
Shouldn't this set to be true in order to bypass early return?
There was a problem hiding this comment.
Good catch, I updated the PR.
There was a problem hiding this comment.
Sorry @jpuri, it's not your changes but setting this to true still leads securityAlertsEnabled as false
This is because of this line in the createMiddleware:
securityAlertsEnabled: securityAlertsEnabled === undefined ?? securityAlertsEnabled,
I think intended usage of this should be
securityAlertsEnabled: securityAlertsEnabled ?? false,
After that, it actually tests the case but fails differently.
There was a problem hiding this comment.
Good point, I updated PR again
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25612 +/- ##
========================================
Coverage 69.60% 69.60%
========================================
Files 1364 1364
Lines 48172 48175 +3
Branches 13291 13292 +1
========================================
+ Hits 33526 33529 +3
Misses 14646 14646 ☔ View full report in Codecov by Sentry. |
Builds ready [b5d8301]
Page Load Metrics (411 ± 309 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Builds ready [6d417f3]
Page Load Metrics (138 ± 152 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Skip blockaid validation for SIWE signatures
Related issues
Fixes: #24189
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist