Skip to content

chore: Update @metamask/smart-transactions-controller from 10.1.2 to 10.1.6#25611

Merged
dan437 merged 2 commits intodevelopfrom
stx-controller
Jul 2, 2024
Merged

chore: Update @metamask/smart-transactions-controller from 10.1.2 to 10.1.6#25611
dan437 merged 2 commits intodevelopfrom
stx-controller

Conversation

@dan437
Copy link
Copy Markdown
Contributor

@dan437 dan437 commented Jul 1, 2024 •
edited by github-actions bot
Loading

Description

This version bump includes updated node module dependencies in the STX controller.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Enable smart transactions in MetaMask Advanced Settings
  2. Try a test transaction and make sure it works

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Jul 1, 2024
@dan437 dan437 requested a review from a team as a code owner July 1, 2024 12:47
@dan437 dan437 changed the title Update @metamask/smart-transactions-controller from 10.1.2 to 10.1.6 chore: Update @metamask/smart-transactions-controller from 10.1.2 to 10.1.6 Jul 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 1, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/smart-transactions-controller@10.1.6 network +17 3.59 MB metamaskbot

🚮 Removed packages: npm/@metamask/smart-transactions-controller@10.1.2

View full report↗︎

antonydenyer
antonydenyer previously approved these changes Jul 1, 2024
View reviewed changes
@dan437
Copy link
Copy Markdown
Contributor Author

dan437 commented Jul 1, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 1, 2024

Policies updated

@metamaskbot metamaskbot requested review from a team as code owners July 1, 2024 13:07
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (fe12ae4) to head (21e77c8).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25611   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48172           
  Branches     13291    13291           
========================================
  Hits         33526    33526           
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 1, 2024

Builds ready [21e77c8]
Page Load Metrics (155 ± 179 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint602391053918
domContentLoaded97828168
load421779155373179
domInteractive97828168
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -92.62 KiB (-2.76%)
  • ui: 0 Bytes (0.00%)
  • common: 12.51 KiB (0.19%)

antonydenyer
antonydenyer approved these changes Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown

@antonydenyer antonydenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan437 dan437 merged commit 548b54a into develop Jul 2, 2024
@dan437 dan437 deleted the stx-controller branch July 2, 2024 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@antonydenyer antonydenyer antonydenyer approved these changes

@dbrans dbrans dbrans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-transactions Transactions team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dan437 @metamaskbot @antonydenyer @dbrans