Skip to content

chore: [Delivery] Update author mapping list for PR#25606

Merged
chloeYue merged 2 commits intodevelopfrom
chloe-update-prauthor
Jul 2, 2024
Merged

chore: [Delivery] Update author mapping list for PR#25606
chloeYue merged 2 commits intodevelopfrom
chloe-update-prauthor

Conversation

@chloeYue
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue commented Jul 1, 2024 •
edited
Loading

Description

Update author team mapping list for PR

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Check new authur/team mapping

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue requested review from a team and kumavis as code owners July 1, 2024 10:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue requested review from benjisclowder and danjm July 1, 2024 10:36
@chloeYue chloeYue self-assigned this Jul 1, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (df81e73) to head (7e8c0e9).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25606   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1365     1365           
  Lines        48198    48198           
  Branches     13297    13297           
========================================
  Hits         33545    33545           
  Misses       14653    14653

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 1, 2024

Builds ready [7e8c0e9]
Page Load Metrics (66 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint70127100157
domContentLoaded104924115
load4110966188
domInteractive104924115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

seaona
seaona approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Q: which is the source of truth of the list?
I see that the teams in github are also not 100% up-to-date, so just wondering what would be the source of truth for this data 🤔
https://github.com/orgs/MetaMask/teams

@chloeYue chloeYue merged commit 03fc8a9 into develop Jul 2, 2024
@chloeYue chloeYue deleted the chloe-update-prauthor branch July 2, 2024 10:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
@chloeYue
Copy link
Copy Markdown
Contributor Author

chloeYue commented Jul 2, 2024 •
edited
Loading

LGTM! Q: which is the source of truth of the list? I see that the teams in github are also not 100% up-to-date, so just wondering what would be the source of truth for this data 🤔 https://github.com/orgs/MetaMask/teams

Hi👋 , yeah the github teams ie not really up to date, i refered to the team topology deck in this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@seaona seaona seaona approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@danjm danjm Awaiting requested review from danjm

+1 more reviewer

@benjisclowder benjisclowder benjisclowder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chloeYue chloeYue

Labels

extension-delivery release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chloeYue @metamaskbot @seaona @benjisclowder