Jl/caip multichain/verify scope method#25589
Merged
adonesky1 merged 7 commits intojl/mmp-2360/caip-25-pocfrom Jun 29, 2024
Merged
Jl/caip multichain/verify scope method#25589adonesky1 merged 7 commits intojl/mmp-2360/caip-25-pocfrom
adonesky1 merged 7 commits intojl/mmp-2360/caip-25-pocfrom
Conversation
…xists for scope in provider_request
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
reviewed
Jun 28, 2024
| } | ||
|
|
||
| const chainId = scope.split(':')[1]; | ||
| // TODO: consider case when scope is defined in requireScopes and optionalScopes |
shanejonas
approved these changes
Jun 28, 2024
adonesky1
reviewed
Jun 28, 2024
| return false; | ||
| }; | ||
|
|
||
| export const flattenScope = ( |
Contributor
There was a problem hiding this comment.
can we just add a jsdoc or comment indicating the formatting case (linking to CAIP-25) this is handling?
adonesky1
reviewed
Jun 28, 2024
| if (!chainId) { | ||
| return end(new Error('missing chainId')); | ||
| if (!scopeObject.methods.includes(wrappedRequest.method)) { | ||
| return end(new Error('unauthorized (method missing in scopeObject)')); |
Contributor
There was a problem hiding this comment.
Suggested change
| return end(new Error('unauthorized (method missing in scopeObject)')); | |
| return end(new Error('unauthorized (method not authorized)')); |
Member
Author
There was a problem hiding this comment.
we were going to come back and decide on proper error codes and messages at a later point haha
adonesky1
reviewed
Jun 28, 2024
Comment on lines
+37
to
+38
| // Do we need to try catch this? | ||
| const { reference } = parseCaipChainId(scope); |
Contributor
There was a problem hiding this comment.
yes for sure, unless we're validating the CAIP-2 scope somewhere above?
Member
Author
There was a problem hiding this comment.
ahh dumb question. When i wrote this i was thinking it wasn't coming from the request for some reason
adonesky1
approved these changes
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist