Skip to content

fix: test#25585

Merged
adonesky1 merged 2 commits intoad/add-signing-methods-to-methodsRequiringNetworkSwitchfrom
ad/add-signing-test
Jun 28, 2024
Merged

fix: test#25585
adonesky1 merged 2 commits intoad/add-signing-methods-to-methodsRequiringNetworkSwitchfrom
ad/add-signing-test

Conversation

@seaona
Copy link
Copy Markdown
Member

@seaona seaona commented Jun 28, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jun 28, 2024
@seaona seaona marked this pull request as ready for review June 28, 2024 16:11
@seaona seaona requested a review from a team as a code owner June 28, 2024 16:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.61%. Comparing base (a7b7d07) to head (a855c3a).

Additional details and impacted files 
@@                                   Coverage Diff                                    @@
##           ad/add-signing-methods-to-methodsRequiringNetworkSwitch   #25585   +/-   ##
========================================================================================
  Coverage                                                    69.61%   69.61%           
========================================================================================
  Files                                                         1351     1351           
  Lines                                                        47946    47946           
  Branches                                                     13220    13220           
========================================================================================
  Hits                                                         33374    33374           
  Misses                                                       14572    14572

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adonesky1 adonesky1 merged commit d3f4b01 into ad/add-signing-methods-to-methodsRequiringNetworkSwitch Jun 28, 2024
@adonesky1 adonesky1 deleted the ad/add-signing-test branch June 28, 2024 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 28, 2024

Builds ready [a855c3a]
Page Load Metrics (43 ± 2 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint62807153
domContentLoaded9171021
load38594352
domInteractive9171021
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0.00%)
  • ui: 50 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seaona @metamaskbot @adonesky1