Skip to content

fix(snaps): Fix alignment of install origin is snap-authorship-expanded#25583

Merged
GuillaumeRx merged 1 commit intodevelopfrom
gr/fix-authorship-origin-alignment
Jul 1, 2024
Merged

fix(snaps): Fix alignment of install origin is snap-authorship-expanded#25583
GuillaumeRx merged 1 commit intodevelopfrom
gr/fix-authorship-origin-alignment

Conversation

@GuillaumeRx
Copy link
Copy Markdown
Contributor

@GuillaumeRx GuillaumeRx commented Jun 28, 2024 •
edited by github-actions bot
Loading

Description

This fixes the expanded authorship install origin being left aligned when the text takes more than a line.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Install a snap with a long install origin
  2. Go to the snap's settings page
  3. Look at the install origin

Screenshots/Recordings

Before

image

After

Screenshot 2024-06-28 at 17 04 27

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner June 28, 2024 15:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Jun 28, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (3ea381d) to head (407adae).

❗ Current head 407adae differs from pull request most recent head 5e676f9

Please upload reports for the commit 5e676f9 to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #25583      +/-   ##
===========================================
+ Coverage    69.60%   69.60%   +0.01%     
===========================================
  Files         1365     1358       -7     
  Lines        48198    48134      -64     
  Branches     13297    13288       -9     
===========================================
- Hits         33545    33503      -42     
+ Misses       14653    14631      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 29, 2024

Builds ready [407adae]
Page Load Metrics (156 ± 179 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint77126101136
domContentLoaded12512794
load481776156372179
domInteractive11512794
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 23 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx force-pushed the gr/fix-authorship-origin-alignment branch from 407adae to 5e676f9 Compare July 1, 2024 10:12
@GuillaumeRx GuillaumeRx force-pushed the gr/fix-authorship-origin-alignment branch from 5e676f9 to e93c1b6 Compare July 1, 2024 14:17
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GuillaumeRx GuillaumeRx merged commit fe12ae4 into develop Jul 1, 2024
@GuillaumeRx GuillaumeRx deleted the gr/fix-authorship-origin-alignment branch July 1, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 1, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 1, 2024

Builds ready [e93c1b6]
Page Load Metrics (212 ± 207 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641541012211
domContentLoaded98429178
load431606212431207
domInteractive98429178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 23 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@hmalik88 hmalik88 hmalik88 approved these changes

Assignees

No one assigned

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeRx @metamaskbot @FrederikBolding @hmalik88