use findNetworkClientIdByChainId hook to get the networkClientId for caip-27 handler#25582
Merged
jiexi merged 3 commits intojl/mmp-2360/caip-25-pocfrom Jun 28, 2024
Merged
Conversation
… for the caip-27 request
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jiexi
reviewed
Jun 28, 2024
| return end(new Error('missing CAIP-25 endowment')); | ||
| } | ||
|
|
||
| const chainId = scope.split(':')[1]; |
Member
There was a problem hiding this comment.
we should try to use our CAIP type helpers
https://github.com/MetaMask/utils/blob/main/src/caip-types.ts#L114
jiexi
reviewed
Jun 28, 2024
| const chainId = scope.split(':')[1]; | ||
|
|
||
| if (!chainId) { | ||
| return end(new Error('missing chainId')); |
Member
There was a problem hiding this comment.
if we use the helper, we can throw the parsing error from the helper back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this uses the findNetworkClientIdByChainId hook to get the networkClientId for caip-27 handler
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist