Skip to content

chore: flaky E2E tests improved#25565

Merged
zone-live merged 14 commits intodevelopfrom
MMI-fixes-e2e-test
Jul 2, 2024
Merged

chore: flaky E2E tests improved#25565
zone-live merged 14 commits intodevelopfrom
MMI-fixes-e2e-test

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Jun 27, 2024 •
edited
Loading

Description

Improvements to our E2E tests.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Jun 27, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 27, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 28, 2024

Builds ready [4f26c5c]
Page Load Metrics (129 ± 164 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7515890189
domContentLoaded9201121
load401613129341164
domInteractive9201121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (7d94797) to head (0fe4634).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25565   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48173    48173           
  Branches     13291    13291           
========================================
  Hits         33527    33527           
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live changed the title chore: passes locally chore: flaky E2E tests improved Jun 28, 2024
@zone-live zone-live marked this pull request as ready for review July 1, 2024 13:24
@zone-live zone-live requested a review from a team as a code owner July 1, 2024 13:24
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [0fe4634]
Page Load Metrics (61 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6312291157
domContentLoaded95627136
load398861136
domInteractive95527136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 7b69e3c into develop Jul 2, 2024
@zone-live zone-live deleted the MMI-fixes-e2e-test branch July 2, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@albertolive albertolive albertolive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mmi DEPRECATED: The product got sunset release-12.2.0 Issue or pull request that will be included in release 12.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zone-live @metamaskbot @albertolive @NidhiKJha