Skip to content

feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension#25555

Merged
jpuri merged 7 commits intodevelopfrom
blockaid_network_support
Jul 3, 2024
Merged

feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension#25555
jpuri merged 7 commits intodevelopfrom
blockaid_network_support

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Jun 27, 2024 •
edited
Loading

Description

Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2716

Manual testing steps

  1. Add networks zkSync, Berachain, Scroll and Metachain One to extension
  2. Submit a malicious transaction on test dapp
  3. Ensure it is reported as malicious

Screenshots/Recordings

Screenshot 2024-07-02 at 6 05 02 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 27, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri force-pushed the blockaid_network_support branch from efd3faf to 6a54e82 Compare June 27, 2024 11:57
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jun 27, 2024
@jpuri jpuri marked this pull request as ready for review June 28, 2024 16:04
@jpuri jpuri requested a review from a team as a code owner June 28, 2024 16:04
@jpuri jpuri changed the title feat: Blockaid network support feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension Jun 28, 2024
@jpuri jpuri marked this pull request as draft June 28, 2024 16:21
@jpuri
Copy link
Copy Markdown
Contributor Author

jpuri commented Jun 28, 2024

Blockaid validations are not working as expected on these networks hence I add DO_NOT_MERGE to the PR.

@jpuri jpuri marked this pull request as ready for review June 28, 2024 16:22
@jpuri jpuri added the DO-NOT-MERGE Pull requests that should not be merged label Jun 28, 2024
@jpuri jpuri removed the DO-NOT-MERGE Pull requests that should not be merged label Jul 2, 2024
@jpuri jpuri requested a review from a team as a code owner July 2, 2024 12:33
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 2, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/ppom_release@1.4.9 network 0 3.34 MB blockaiduser
npm/@metamask/ppom-validator@0.32.0 Transitive: environment, filesystem, unsafe +34 4.45 MB metamaskbot

🚮 Removed packages: npm/@blockaid/ppom_release@1.4.8, npm/@metamask/ppom-validator@0.31.0

View full report↗︎

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [0bae4fb]
Page Load Metrics (72 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81133102136
domContentLoaded106030115
load5211072157
domInteractive106030115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 76 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 346 Bytes (0.01%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.57%. Comparing base (1f74b08) to head (0bae4fb).
Report is 28 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25555   +/-   ##
========================================
  Coverage    69.57%   69.57%           
========================================
  Files         1360     1360           
  Lines        48172    48174    +2     
  Branches     13296    13296           
========================================
+ Hits         33513    33515    +2     
  Misses       14659    14659

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 4d93e69 into develop Jul 3, 2024
@jpuri jpuri deleted the blockaid_network_support branch July 3, 2024 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpuri @metamaskbot @pedronfigueiredo @vinistevam