chore(deps): bump assets controller to v34.0.0 by montelaidev · Pull Request #25540 · MetaMask/metamask-extension

montelaidev · 2024-06-27T00:12:04Z

Description

This PR bumps @metamask/assets-controllers to ^34.0.0.

Related issues

Fixes https://github.com/MetaMask/accounts-planning/issues/481

Manual testing steps

This PR affects all assets related tokens

Test added and removing of and tokens
Transfer tokens
Turn on off token detection and see the detected tokens
Check if the token rate values on mainnet

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-27T00:12:17Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-06-27T00:13:34Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/accounts-controller@17.1.1	Transitive: environment, filesystem, network	`+41`	7.8 MB
npm/@metamask/assets-controllers@34.0.0	Transitive: environment	`+22`	4.21 MB	metamaskbot

🚮 Removed packages: npm/@metamask/accounts-controller@17.0.0, npm/@metamask/assets-controllers@33.0.0

View full report↗︎

montelaidev · 2024-06-27T00:20:22Z

@metamaskbot update-policies

montelaidev · 2024-06-27T00:13:03Z

app/scripts/metamask-controller.actions.test.js

-      const supportsInterfaceStub = jest.fn().mockResolvedValue(false);
-      jest
-        .spyOn(metamaskController.tokensController, '_createEthersContract')
-        .mockResolvedValue({ supportsInterface: supportsInterfaceStub });
-


No longer part of tokens controller

montelaidev · 2024-06-27T00:20:56Z

app/scripts/metamask-controller.actions.test.js

-      const supportsInterfaceStub = jest.fn().mockResolvedValue(false);
-      jest
-        .spyOn(metamaskController.tokensController, '_createEthersContract')
-        .mockResolvedValue({ supportsInterface: supportsInterfaceStub });


No longer part of tokens controller

metamaskbot · 2024-06-27T00:25:37Z

Policy update failed. You can review the logs or retry the policy update here

…ansaction-controllers

montelaidev · 2024-06-27T12:39:31Z

@metamaskbot update-policies

metamaskbot · 2024-06-27T12:50:02Z

Policies updated

…ansaction-controllers

codecov · 2024-06-27T16:11:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.70%. Comparing base (b37e39d) to head (0485474).
Report is 7 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25540      +/-   ##
===========================================
+ Coverage    69.68%   69.70%   +0.02%     
===========================================
  Files         1358     1358              
  Lines        48079    48064      -15     
  Branches     13262    13260       -2     
===========================================
- Hits         33501    33499       -2     
+ Misses       14578    14565      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-27T16:22:12Z

Builds ready [463b447]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (139 ± 190 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	123	78	13	6
		domContentLoaded	9	20	11	2	1
		load	41	1861	139	395	190
		domInteractive	9	20	11	2	1

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.78 KiB (-0.05%)
ui: 0 Bytes (0.00%)
common: 1.39 KiB (0.02%)

…ansaction-controllers

metamaskbot · 2024-06-28T07:44:21Z

Builds ready [53617fe]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (156 ± 163 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	348	115	57	27
		domContentLoaded	9	68	27	19	9
		load	42	1620	156	339	163
		domInteractive	9	68	27	19	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.97 KiB (-0.06%)
ui: 0 Bytes (0.00%)
common: 1.39 KiB (0.02%)

app/scripts/metamask-controller.test.js

ccharly · 2024-06-28T12:11:36Z

I did run a very small tests where I add tokens, and it was working fine:

Screen.Recording.2024-06-28.at.12.06.04.mov

metamaskbot · 2024-06-28T13:25:13Z

Builds ready [0485474]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (275 ± 289 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	306	117	48	23
		domContentLoaded	10	79	32	21	10
		load	48	2398	275	601	289
		domInteractive	10	79	31	21	10

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.97 KiB (-0.06%)
ui: 0 Bytes (0.00%)
common: 1.39 KiB (0.02%)

plasmacorral · 2024-06-28T22:36:31Z

Tested mac sonoma 14.5, Chrome 126.0.6478.127 and Firefox: 127.0.2
Used HD, Imported Snap, QR, Ledger accounts

Migration- imported tokens persisted through update (tested on Chrome only)
Import autodetected tokens
- Hide autodetected imported token
- Re-import removed token
- Imported Orangefox assets on all networks from add list
Turn off Token Autodetection in settings>Security & Privacy
Manual token import
- By contract address
- By search
Autodetect NFTs
- Turn on autodetect and:
  - see NFTs
  - imported NFTs persist
  - Keep display NFT media on
  - Turn off Display NFT media, keeping autodetect off
  - Turn on Display NFT media, keeping autodetect off
- Turn off autodetect
  - Imported NFTs continue to display even after lock/unlock
Manual NFT import 721 & 1155
Send NFT 721 & 1155
Switch selected account
Add networks
Switch networks
Test dapp
- ERC 20/721/1155
  - Deploy
  - Approve
  - Send
  - Reject
  - Import to wallet
- Send
  - Legacy
  - 1559
  - 1559 w/o gas

Observed some delay on Polygon asset prices in Firefox, but on retest was not able to reproduce and prices appeared immediately after import.

LGTM!

chore(deps): bump assets and transaction controller

fde8380

metamaskbot added the team-accounts-framework Accounts team label Jun 27, 2024

montelaidev removed the team-accounts-framework Accounts team label Jun 27, 2024

montelaidev self-assigned this Jun 27, 2024

montelaidev added the team-accounts-framework Accounts team label Jun 27, 2024

montelaidev added 2 commits June 27, 2024 08:19

revert: deleted test

c9d40f2

fix: dedupe

4b0ea16

montelaidev commented Jun 27, 2024

View reviewed changes

montelaidev added 2 commits June 27, 2024 18:48

fix: update policy

3940779

Merge remote-tracking branch 'origin/develop' into bump-assets-and-tr…

eeacdbe

…ansaction-controllers

Update LavaMoat policies

2456040

fix: revert transaction controller bump

5914acc

montelaidev changed the title ~~chore(deps): bump assets and transaction controller~~ chore(deps): bump assets controller to v34.0.0 Jun 27, 2024

fix:test

cf9dbd7

montelaidev marked this pull request as ready for review June 27, 2024 14:44

montelaidev requested review from a team as code owners June 27, 2024 14:44

montelaidev added the DO-NOT-MERGE Pull requests that should not be merged label Jun 27, 2024

Merge remote-tracking branch 'origin/develop' into bump-assets-and-tr…

463b447

…ansaction-controllers

montelaidev added 2 commits June 28, 2024 14:17

fix: update test

cab8736

Merge remote-tracking branch 'origin/develop' into bump-assets-and-tr…

53617fe

…ansaction-controllers

ccharly reviewed Jun 28, 2024

View reviewed changes

app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved

fix: update test

0485474

ccharly approved these changes Jun 28, 2024

View reviewed changes

gantunesr approved these changes Jun 28, 2024

View reviewed changes

plasmacorral added QA Passed and removed DO-NOT-MERGE Pull requests that should not be merged labels Jun 28, 2024

plasmacorral merged commit f353f0c into develop Jun 28, 2024

plasmacorral deleted the bump-assets-and-transaction-controllers branch June 28, 2024 22:42

github-actions bot locked and limited conversation to collaborators Jun 28, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jun 28, 2024

Conversation

montelaidev commented Jun 27, 2024 • edited by plasmacorral Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 27, 2024

Uh oh!

socket-security bot commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

montelaidev commented Jun 27, 2024

Uh oh!

montelaidev Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

montelaidev Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jun 27, 2024

Uh oh!

montelaidev commented Jun 27, 2024

Uh oh!

metamaskbot commented Jun 27, 2024

Uh oh!

codecov bot commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jun 27, 2024

Uh oh!

metamaskbot commented Jun 28, 2024

Uh oh!

Uh oh!

ccharly commented Jun 28, 2024

Uh oh!

metamaskbot commented Jun 28, 2024

Uh oh!

plasmacorral commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

montelaidev commented Jun 27, 2024 •

edited by plasmacorral

Loading

socket-security bot commented Jun 27, 2024 •

edited

Loading

codecov bot commented Jun 27, 2024 •

edited

Loading

plasmacorral commented Jun 28, 2024 •

edited

Loading